Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29345400: Issue 4093 - Adapt unit tests for changes to Subscription.title (Closed)

Created:
May 31, 2016, 10:22 a.m. by Wladimir Palant
Modified:
May 31, 2016, 10:37 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4093 - Adapt unit tests for changes to Subscription.title Repository: hg.adblockplus.org/adblockplustests

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/content/tests/subscriptionClasses.js View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 4
Wladimir Palant
May 31, 2016, 10:22 a.m. (2016-05-31 10:22:04 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29345400/diff/29345401/chrome/content/tests/subscriptionClasses.js File chrome/content/tests/subscriptionClasses.js (right): https://codereview.adblockplus.org/29345400/diff/29345401/chrome/content/tests/subscriptionClasses.js#newcode36 chrome/content/tests/subscriptionClasses.js:36: compareSubscription("~fl~", ["url=~fl~"]); Didn't we completely removed that syntax?
May 31, 2016, 10:28 a.m. (2016-05-31 10:28:35 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29345400/diff/29345401/chrome/content/tests/subscriptionClasses.js File chrome/content/tests/subscriptionClasses.js (right): https://codereview.adblockplus.org/29345400/diff/29345401/chrome/content/tests/subscriptionClasses.js#newcode36 chrome/content/tests/subscriptionClasses.js:36: compareSubscription("~fl~", ["url=~fl~"]); On 2016/05/31 10:28:34, Sebastian Noack wrote: > ...
May 31, 2016, 10:32 a.m. (2016-05-31 10:32:59 UTC) #3
Sebastian Noack
May 31, 2016, 10:33 a.m. (2016-05-31 10:33:58 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld