Issue 4045 - Add Test Suite To CMS

cms/tests/dynamic_tests/conftest.py

+import os
+import pytest
+
+SOURCEPATH = 'cms/tests/test_site/pages/'

[Vasily Kuznetsov, 2016/07/01 14:26:15]

It's better to not use relative paths like this to not depend on where the tests
are run from. You can use __file__ global, os.path.dirname and os.path.join to
get to where you want.

[Jon Sonesen, 2016/07/01 15:58:13]

Thanks for the tip I will get that fixed up.

+
+
+@pytest.fixture(scope='session', autouse=True)
+def dynamic_session_setup(request):
+    seen = set()
+    session = request.node
+    for item in session.items:
+        cls = item.getparent(pytest.Class)
+        if cls not in seen:
+            if hasattr(cls.obj, 'run_test_server'):

[Vasily Kuznetsov, 2016/07/01 14:26:15]

Why not just run the test server in this fixture? Then we wouldn't need the
classes and `item.getparent`, which I think is not really a documented feature
that we can safely rely on.

[Jon Sonesen, 2016/07/01 15:58:13]

Yeah I agree, I am going to include the setup/teardown code for both static and
dynamic tests in this fixture.

+                seen.add(cls)
+                p = cls.obj.run_test_server()
+
+    def dynamic_tear_down():
+        p.terminate()
+    request.addfinalizer(dynamic_tear_down)

[Sebastian Noack, 2016/07/01 14:56:23]

Note that the wrapper function is redundant. You can just call:

  request.addfinalizer(p.terminate)

[Jon Sonesen, 2016/07/01 15:58:13]

Thank you, however once the teardown for static and dynamic are included here
won't that change?

+
+
+@pytest.fixture(scope='session')
+def get_pages():
+    return_data = set()
+    print os.walk(SOURCEPATH)
+    for (dirpath, dirnames, filenames) in os.walk(SOURCEPATH):
+        for input_file in filenames:
+                return_data.add(input_file)
+    return return_data