cms/tests/dynamic_tests/test_dynamic.py - Issue 29345468: Issue 4045 - Add Test Suite To CMS

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: cms/tests/dynamic_tests/test_dynamic.py

Issue 29345468: Issue 4045 - Add Test Suite To CMS (Closed)

Patch Set: fix Popen object return Created June 29, 2016, 1:23 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 import urllib2

	2 import os

	3

	4

	5 class TestDynamic:

	6 @classmethod

	7 def run_test_server(cls):

	8 import subprocess

	9 import sys

	10 sys.path.insert(0, '../')

	11 return subprocess.Popen(

	12 ['python', 'runserver.py', 'cms/tests/test_site']

	13 )

	14

	15 def test_template(self, get_pages):

	16 for page in get_pages:

	17 url = 'http://localhost:5000/root/{}'\
	Vasily Kuznetsov 2016/07/01 14:26:15 This code would be encapsulated in the `get_page` This code would be encapsulated in the `get_page` fixture. Jon Sonesen 2016/07/01 15:58:13 Will do. Show quoted text On 2016/07/01 14:26:15, Vasily Kuznetsov wrote: > This code would be encapsulated in the `get_page` fixture. Will do.
	18 .format(os.path.splitext(page))
	Sebastian Noack 2016/07/01 14:56:23 I wonder whether this code behaves as intended sin I wonder whether this code behaves as intended since os.path.splitext() returns a tuple? Also, if just concatenating two strings, use the + operator. Jon Sonesen 2016/07/01 15:58:13 the test server does return 200, and the page cont Show quoted text On 2016/07/01 14:56:23, Sebastian Noack wrote: > I wonder whether this code behaves as intended since os.path.splitext() returns > a tuple? Also, if just concatenating two strings, use the + operator. the test server does return 200, and the page contents and pass the test but it is still wrong and seems sloppy so I will address it.
	19 response = urllib2.urlopen(url)

	20 assert response.code == 200

OLD	NEW