Issue 4099 - Don't enforce Gecko build IDs to be numerical

build.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import sys
 import re
 import subprocess
 import shutil
 import buildtools
@@ skipping 167 matching lines @@
 def runBuild(baseDir, scriptName, opts, args, type):
     locales = None
     buildNum = None
     multicompartment = False
     releaseBuild = False
     keyFile = None
     for option, value in opts:
         if option in ('-l', '--locales'):
             locales = value.split(',')
         elif option in ('-b', '--build'):
-            buildNum = int(value)
+            buildNum = value

[Vasily Kuznetsov, 2016/06/01 16:08:53]

So now that `buildNum` is a string maybe we can also remove `buildNum =
str(buildNum)` in `packager.getBuildVersion`?

[Wladimir Palant, 2016/06/01 17:16:42]

Right, I don't think anything is still passing in numbers here.

+            if type != 'gecko' and not re.search(r'^\d+$', buildNum):
+                raise TypeError('Build number must be numerical')
         elif option in ('-k', '--key'):
             keyFile = value
         elif option in ('-m', '--multi-compartment'):
             multicompartment = True
         elif option in ('-r', '--release'):
             releaseBuild = True
     outFile = args[0] if len(args) > 0 else None
 
     if type == 'gecko':
         import buildtools.packagerGecko as packager
@@ skipping 409 matching lines @@
                 if option in ('-h', '--help'):
                     usage(scriptName, type, command)
                     sys.exit()
             commands[command](baseDir, scriptName, opts, args, type)
         else:
             print 'Command %s is not supported for this application type' % command
             usage(scriptName, type)
     else:
         print 'Command %s is unrecognized' % command
         usage(scriptName, type)