Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(300)

Issue 29345630: Issue 4131 - Simplify UI initialization logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by Wladimir Palant
Modified:
3 years, 5 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 4131 - Simplify UI initialization logic Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -47 lines) Patch
M lib/ui.js View 1 1 chunk +39 lines, -47 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 6 months ago (2016-06-07 16:21:48 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29345630/diff/29345631/lib/ui.js File lib/ui.js (right): https://codereview.adblockplus.org/29345630/diff/29345631/lib/ui.js#newcode281 lib/ui.js:281: let promises = []; Detail: That variable name is ...
3 years, 6 months ago (2016-06-08 15:47:33 UTC) #2
Wladimir Palant
Note: Changes from https://issues.adblockplus.org/ticket/4133 show up in the interdiff due to rebasing. https://codereview.adblockplus.org/29345630/diff/29345631/lib/ui.js File lib/ui.js ...
3 years, 6 months ago (2016-06-08 20:51:30 UTC) #3
Thomas Greiner
3 years, 5 months ago (2016-06-13 13:22:33 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5