Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(275)

Issue 29345636: Issue 1414 - Document how to build libadblockplus for Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 6 months ago by anton
Modified:
3 years, 5 months ago
Reviewers:
Wladimir Palant, sergei
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 1414 - Document how to build libadblockplus for Android

Patch Set 1 #

Total comments: 13

Patch Set 2 : With some Sergey's suggestions #

Total comments: 9

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M README.md View 1 2 3 4 5 2 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 12
anton
Building for android is pretty straight-forward and the main problem is getting appropriate android ndk ...
3 years, 6 months ago (2016-06-08 13:32:30 UTC) #1
sergei
Cool, however I have several notes. https://codereview.adblockplus.org/29345636/diff/29345637/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345637/README.md#newcode61 README.md:61: * clang 3.4 ...
3 years, 6 months ago (2016-06-08 15:32:36 UTC) #2
anton
On 2016/06/08 15:32:36, sergei wrote: > Cool, however I have several notes. > > https://codereview.adblockplus.org/29345636/diff/29345637/README.md ...
3 years, 5 months ago (2016-06-09 10:46:34 UTC) #3
sergei
https://codereview.adblockplus.org/29345636/diff/29345637/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345637/README.md#newcode61 README.md:61: * clang 3.4 for Android (from android-ndk-r9, r10c) >> ...
3 years, 5 months ago (2016-06-10 11:36:01 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29345636/diff/29345686/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345686/README.md#newcode28 README.md:28: You can download *android-ndk-r10c* for [Win 32](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86.exe), [Win 64](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86_64.exe), ...
3 years, 5 months ago (2016-06-10 21:54:56 UTC) #5
anton
https://codereview.adblockplus.org/29345636/diff/29345637/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345637/README.md#newcode61 README.md:61: * clang 3.4 for Android (from android-ndk-r9, r10c) On ...
3 years, 5 months ago (2016-06-14 07:16:47 UTC) #6
anton
https://codereview.adblockplus.org/29345636/diff/29345686/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345686/README.md#newcode28 README.md:28: You can download *android-ndk-r10c* for [Win 32](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86.exe), [Win 64](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86_64.exe), ...
3 years, 5 months ago (2016-06-14 07:30:30 UTC) #7
sergei
https://codereview.adblockplus.org/29345636/diff/29345686/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345686/README.md#newcode28 README.md:28: You can download *android-ndk-r10c* for [Win 32](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86.exe), [Win 64](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86_64.exe), ...
3 years, 5 months ago (2016-06-14 08:05:29 UTC) #8
anton
https://codereview.adblockplus.org/29345636/diff/29345686/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29345686/README.md#newcode28 README.md:28: You can download *android-ndk-r10c* for [Win 32](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86.exe), [Win 64](http://dl.google.com/android/ndk/android-ndk-r10c-windows-x86_64.exe), ...
3 years, 5 months ago (2016-06-14 08:07:29 UTC) #9
sergei
LGTM after addressing the comment. https://codereview.adblockplus.org/29345636/diff/29346666/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29346666/README.md#newcode18 README.md:18: ### Supported compilers I ...
3 years, 5 months ago (2016-06-20 15:11:25 UTC) #10
Wladimir Palant
LGTM except for two nits from me. https://codereview.adblockplus.org/29345636/diff/29346668/README.md File README.md (right): https://codereview.adblockplus.org/29345636/diff/29346668/README.md#newcode32 README.md:32: * the ...
3 years, 5 months ago (2016-06-20 15:17:51 UTC) #11
anton
3 years, 5 months ago (2016-06-20 15:31:24 UTC) #12
https://codereview.adblockplus.org/29345636/diff/29346668/README.md
File README.md (right):

https://codereview.adblockplus.org/29345636/diff/29346668/README.md#newcode32
README.md:32: * the host system should be linux or OS X
On 2016/06/20 15:17:51, Wladimir Palant wrote:
> Nit: it should be "The" and "Linux" (capitalized).

Acknowledged.

https://codereview.adblockplus.org/29345636/diff/29346668/README.md#newcode33
README.md:33: * android-ndk-r9, android-ndk-r10c. You can download the latter
for [OS X](http://dl.google.com/android/ndk/android-ndk-r10c-darwin-x86_64.bin),
[Linux 32](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86.bin),
[Linux 64](http://dl.google.com/android/ndk/android-ndk-r10c-linux-x86_64.bin)
On 2016/06/20 15:17:51, Wladimir Palant wrote:
> Nit: period at the end of this sentence please.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5