Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29345636: Issue 1414 - Document how to build libadblockplus for Android (Closed)
Patch Set: Created June 8, 2016, 1:26 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -53,21 +53,33 @@
### Supported compilers
You need a C++11 compatible compiler to build libadblockplus.
The compilation was tested with the following compilers:
* g++ 4.8
* Microsoft Visual Studio 2010, 2012
-* clang 3.4 for Android (from android-ndk-r9)
+* clang 3.4 for Android (from android-ndk-r9, r10c)
sergei 2016/06/08 15:32:35 It's actually can be quite tricky to find the link
sergei 2016/06/08 15:32:35 It also makes sense to say may be after the list o
sergei 2016/06/10 11:36:01 Yeah, but unfortunately we cannot achieve it right
sergei 2016/06/10 11:36:01 Honestly I personally have not tried to compile it
anton 2016/06/14 07:16:46 i've tried to compile with gcc-4.9 from r11c symli
* clang 3.6 for OS X
If you have a question about another compiler please [create an issue](https://issues.adblockplus.org/).
+### Building for Android
sergei 2016/06/08 15:32:35 I think it should be before "Supported compilers"
anton 2016/06/14 07:16:46 Done.
anton 2016/06/14 07:16:46 Done.
+
+First set ANDROID_NDK_ROOT environment variable to your Android NDK directory.
sergei 2016/06/08 15:32:35 It would be better if you could include an example
sergei 2016/06/08 15:32:35 There is additional space character between NDK an
sergei 2016/06/10 11:36:01 Fair enough, albeit I guess nobody is trying to co
anton 2016/06/14 07:16:46 Done.
anton 2016/06/14 07:16:46 Not sure it's needed as i assume people trying to
+
+To build for *x86* arch run:
+
+ make android_x86
+
+To build for *arm* arch run:
+
+ make android_arm
+
Usage
-----
You can use libadblockplus to build an ad blocker. Or, strictly speaking, a web
content filter. Just like Adblock Plus, it can detect resources that should be
blocked based on their URL and context information, and generate CSS selectors
to hide DOM elements.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld