Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(463)

Issue 29345731: Issue 4142 - Update ABP icon in FF toolbar to support for high resolution screens (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Wladimir Palant
Modified:
3 years, 7 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

This only replaces the 16x16 icon on high-dpi screens for now. In order to do the same for the 32x32 icon we need larger images. Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -2 lines) Patch
M chrome/skin/overlay.css View 1 chunk +53 lines, -2 lines 3 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 7 months ago (2016-06-09 14:27:29 UTC) #1
saroyanm
https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay.css File chrome/skin/overlay.css (right): https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay.css#newcode123 chrome/skin/overlay.css:123: #abp-toolbarbutton, Are this rules and one below still being ...
3 years, 7 months ago (2016-06-10 10:21:58 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay.css File chrome/skin/overlay.css (right): https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay.css#newcode123 chrome/skin/overlay.css:123: #abp-toolbarbutton, On 2016/06/10 10:21:58, saroyanm wrote: > Are this ...
3 years, 7 months ago (2016-06-10 14:53:27 UTC) #3
saroyanm
3 years, 7 months ago (2016-06-10 16:58:19 UTC) #4
LGTM

https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay...
File chrome/skin/overlay.css (right):

https://codereview.adblockplus.org/29345731/diff/29345732/chrome/skin/overlay...
chrome/skin/overlay.css:123: #abp-toolbarbutton,
On 2016/06/10 14:53:27, Wladimir Palant wrote:
> On 2016/06/10 10:21:58, saroyanm wrote:
> > Are this rules and one below still being used by any of our products ?
> > Feels like this only for old versions for FF according to this ->
> >
>
https://blog.mozilla.org/addons/2011/02/16/toolbar-buttons-firefox-4-revisited/
> 
> You are right, Firefox no longer uses 24x24 icons - however, SeaMonkey still
> does. By default, we are in the Bookmarks Toolbar there, but the user has the
> option to move our icon to the Navigation Toolbar. And it is a classic toolbar
> with 24x24 icons.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5