Issue 4146 - Fix failing UpdateCheckTest.testApplicationUpdateAvailable test in libadblockplus-andr…

libadblockplus-android/jni/JniJsValue.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef JNIJSVALUE_H
 #define JNIJSVALUE_H
 
 #include <jni.h>
 #include <AdblockPlus/JsValue.h>
 
 void JniJsValue_OnLoad(JavaVM* vm, JNIEnv* env, void* reserved);
 
+void JniJsValue_OnUnload(JavaVM* vm, JNIEnv* env, void* reserved);
+
 jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue, jclass jsValueClass = 0);
 
 jobject JniJsValueListToArrayList(JNIEnv* env, AdblockPlus::JsValueList& list);
 
 AdblockPlus::JsValue* JniGetJsValue(jlong ptr);
 
 AdblockPlus::JsValuePtr& JniGetJsValuePtr(jlong ptr);
 
-void JniJsValue_OnUnload(JavaVM *vm, JNIEnv *env, void *reserved);

[Felix Dahlke, 2016/09/15 13:01:19]

Nit: Maybe it's just me, but I think I'd find it easier if OnUnload comes right
after OnLoad, similar to how destructors are typically listed right after
constructors.

[anton, 2016/09/15 13:28:18]

Acknowledged.

-
 #endif /* JNIJSVALUE_H */