Issue 4028 - Add support for Edge extensions to buildtools

packager.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Note: These are the base functions common to all packagers, the actual
 # packagers are implemented in packagerGecko and packagerChrome.
 
 import sys
 import os
 import re
-import codecs

[Sebastian Noack, 2016/07/01 15:56:03]

I suppose you can remove the respective putty-ignore for A301 from tox.ini now?

[Vasily Kuznetsov, 2016/07/01 19:51:28]

It seems that there's no A301 ignore for this file (and I'm reluctant to also
fix this in other unrelated places).

[Sebastian Noack, 2016/07/05 14:30:37]

You are right. Importing codecs doesn't cause a A301, using codecs.open would.
However, I suppose F401 (unused import) doesn't need to be ignored for this file
anymore now.

[Vasily Kuznetsov, 2016/07/07 16:23:48]

Done.

 import subprocess
 import json
 import zipfile
 from StringIO import StringIO
 from chainedconfigparser import ChainedConfigParser
 
 import buildtools
 
 
 def getDefaultFileName(metadata, version, ext):
@@ skipping 41 matching lines @@
                 # version components.
                 while version.count('.') < 2:
                     version += '.0'
             version += '.' + buildNum
     return version
 
 
 def getTemplate(template, autoEscape=False):
     import jinja2
 
-    templatePath = buildtools.__path__[0]
+    templatePath = os.path.join(buildtools.__path__[0], 'templates')

[Sebastian Noack, 2016/07/01 15:56:04]

While changing every line using this variable, mind using underscores instead
camel case?

[Vasily Kuznetsov, 2016/07/01 19:51:28]

Done.

+    loader = jinja2.FileSystemLoader(templatePath)
     if autoEscape:
-        env = jinja2.Environment(loader=jinja2.FileSystemLoader(templatePath), autoescape=True)
+        env = jinja2.Environment(loader=loader, autoescape=True)
     else:
-        env = jinja2.Environment(loader=jinja2.FileSystemLoader(templatePath))
+        env = jinja2.Environment(loader=loader)
     env.filters.update({'json': json.dumps})
     return env.get_template(template)
 
 
 class Files(dict):
     def __init__(self, includedFiles, ignoredFiles, process=None):
         self.includedFiles = includedFiles
         self.ignoredFiles = ignoredFiles
         self.process = process
 
@@ skipping 51 matching lines @@
         names = self.keys()
         names.sort(key=sortKey)
         for name in names:
             zip.writestr(name, self[name])
         zip.close()
 
     def zipToString(self, sortKey=None):
         buffer = StringIO()
         self.zip(buffer, sortKey=sortKey)
         return buffer.getvalue()