templates/edge/AppxBlockMap.xml.tmpl - Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: templates/edge/AppxBlockMap.xml.tmpl

Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools (Closed)

Patch Set: Address comments on patch set 7 Created Oct. 4, 2016, 2:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8" standalone="no"?>

	2 <BlockMap xmlns="http://schemas.microsoft.com/appx/2010/blockmap" HashMethod="ht tp://www.w3.org/2001/04/xmlenc#sha256">

	3 {% for file in files -%}

	4 <File Name="{{file.name}}" Size="{{file.size}}" LfhSize="{{file.lfh_size}}">

	5 {% for block in file.blocks -%}

	6 <Block Hash="{{block.hash}}" {% if block.compressed_size %}Size="{{block.com pressed_size}}"{% endif %}/>
	Sebastian Noack 2016/10/04 19:58:06 If it turns out that we won't need to add compress If it turns out that we won't need to add compression later (because it gets repackaged by the Store anyway) this logic should be removed before this lands. Vasily Kuznetsov 2016/10/11 15:58:28 Done. I also removed all compression-related logic Show quoted text On 2016/10/04 19:58:06, Sebastian Noack wrote: > If it turns out that we won't need to add compression later (because it gets > repackaged by the Store anyway) this logic should be removed before this lands. Done. I also removed all compression-related logic from everywhere else and closed https://issues.adblockplus.org/ticket/4149.
	7 {% endfor -%}

	8 </File>

	9 {% endfor -%}

	10 </BlockMap>

OLD	NEW