tox.ini - Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29345751: Issue 4028 - Add support for Edge extensions to buildtools (Closed)

Left Patch Set: Address comments on patch set 1 Created June 17, 2016, 5:51 p.m.

Right Patch Set: Address Windows Store issues with blockmap and devbuild display name Created Oct. 14, 2016, 12:07 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27	2 envlist = py27

3 skipsdist = true	3 skipsdist = true

4	4

5 [flake8]	5 [flake8]

6 putty-ignore =	6 putty-ignore =

7 build.py : A102,A104,A107,A201,A206,A302,E501,E711,F401,N802,N803,N806	7 build.py : A102,A104,A107,A201,A206,A302,E501,E711,F401,N802,N803,N806

8 chainedconfigparser.py : A107,E501	8 chainedconfigparser.py : A107,E501

9 ensure_dependencies.py : A102,A107,A108,A302,E129,E501,E713,E721,F821	9 ensure_dependencies.py : A102,A107,A108,A302,E129,E501,E713,E721,F821

10 localeTools.py : A103,A104,A107,A108,A206,A301,A302,E129,E501,E711,E713,F401 ,F812,N802,N803,N806	10 localeTools.py : A103,A104,A107,A108,A206,A301,A302,E129,E501,E711,E713,F401 ,F812,N802,N803,N806

11 packager.py : A102,A107,A206,A302,E501,E711,F401,N802,N803,N806	11 packager.py : A102,A107,A206,A302,E501,E711,N802,N803,N806

12 packagerChrome.py : A101,A104,A105,A107,A108,A111,A112,A302,E129,E501,E711,E 713,E731,F401,F841,N802,N803,N806	12 packagerChrome.py : A101,A104,A105,A107,A108,A111,A112,A302,E129,E501,E711,E 713,E731,F401,F841,N802,N803,N806

13 packagerEdge.py : A302,N802,N803,N806
Sebastian Noack 2016/07/01 15:56:04 Well, the point of using putty-ignore is not to ma Well, the point of using putty-ignore is not to make this list even larger, but to make sure that new code complies and existing code doesn't get any worse. So please remove this line and fix any warning. Vasily Kuznetsov 2016/07/01 19:51:29 Unfortunately to preserve the API of the packagers Show quoted text On 2016/07/01 15:56:04, Sebastian Noack wrote: > Well, the point of using putty-ignore is not to make this list even larger, but > to make sure that new code complies and existing code doesn't get any worse. So > please remove this line and fix any warning. Unfortunately to preserve the API of the packagers `createBuild` name and arguments had to remain matching past convention (marked with # noqa) but everything else is fixed.
14 packagerGecko.py : A101,A104,A105,A107,A108,A201,A302,E501,E711,E713,F401,N8 02,N803,N806	13 packagerGecko.py : A101,A104,A105,A107,A108,A201,A302,E501,E711,E713,F401,N8 02,N803,N806

15 packagerSafari.py : A101,A107,A301,A302,E501,N802,N803,N806	14 packagerSafari.py : A101,A107,A301,A302,E501,N802,N803,N806

16 publicSuffixListUpdater.py : A108,E501,F821,N802,N803	15 publicSuffixListUpdater.py : A108,E501,F821,N802,N803

17 releaseAutomation.py : A102,A107,A108,A302,E501,F401,N803,N806	16 releaseAutomation.py : A102,A107,A108,A302,E501,F401,N803,N806

18	17

19 [testenv]	18 [testenv]

20 basepython=python2	19 setenv =
Sebastian Noack 2016/07/01 15:56:04 (Why) is this necessary? (Why) is this necessary? Vasily Kuznetsov 2016/07/01 19:51:29 Hm. Actually it's not. Perhaps I added this line w Show quoted text On 2016/07/01 15:56:04, Sebastian Noack wrote: > (Why) is this necessary? Hm. Actually it's not. Perhaps I added this line when there was some other environment called something else than pyXX and then later removed that environment. Anyway, good catch, thanks.
	20 PYTHONPATH = {toxinidir}/..

21 deps =	21 deps =

22 pytest	22 pytest

23 jinja2	23 jinja2

24 flake8	24 # flake8-putty is not yet compatible with flake8 3.0

	25 flake8==2.*

25 flake8-putty	26 flake8-putty

26 pep8-naming	27 pep8-naming

27 hg+https://hg.adblockplus.org/codingtools#egg=flake8-abp&subdirectory=flake8 -abp	28 hg+https://hg.adblockplus.org/codingtools#egg=flake8-abp&subdirectory=flake8 -abp

28 commands =	29 commands =

29 python ensure_dependencies.py	30 python ensure_dependencies.py

30 py.test tests	31 py.test tests

31 flake8 --exclude jshydra	32 flake8 --exclude jshydra

LEFT	RIGHT