Issue 4028 - Add support for Edge extensions to buildtools

packager.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 # Note: These are the base functions common to all packagers, the actual
 # packagers are implemented in packagerGecko and packagerChrome.
 
 import sys
 import os
 import re
@@ skipping 116 matching lines @@
 
     def preprocess(self, filenames, params={}):
         import jinja2
         env = jinja2.Environment()
 
         for filename in filenames:
             env.autoescape = os.path.splitext(filename)[1].lower() in ('.html', '.xml')
             template = env.from_string(self[filename].decode('utf-8'))
             self[filename] = template.render(params).encode('utf-8')
 
-    def zip(self, outFile, sortKey=None, compress=True):

[Sebastian Noack, 2016/10/04 19:58:05]

Perhaps it is a little simpler if you just pass the compression argument
through?

  def zip(self, outFile, sortKey=None, compression=zipfile.ZIP_DEFLATED):
    ...

[Vasily Kuznetsov, 2016/10/11 15:58:28]

Done.

-        compression = zipfile.ZIP_DEFLATED if compress else zipfile.ZIP_STORED
-        zf = zipfile.ZipFile(outFile, 'w', compression)

[Sebastian Noack, 2016/10/04 19:58:05]

While changing this code anyway, use with-statement?

[Vasily Kuznetsov, 2016/10/11 15:58:27]

Done.

-        for name in sorted(self, key=sortKey):
-            zf.writestr(name, self[name])
-        zf.close()
+    def zip(self, outFile, sortKey=None, compression=zipfile.ZIP_DEFLATED):
+        with zipfile.ZipFile(outFile, 'w', compression) as zf:
+            for name in sorted(self, key=sortKey):
+                zf.writestr(name, self[name])
 
     def zipToString(self, sortKey=None):
         buffer = StringIO()
         self.zip(buffer, sortKey=sortKey)
         return buffer.getvalue()