.csscomb.json - Issue 29346536: Issue 4155 - Created global csscomb config

Side by Side Diff: .csscomb.json

Issue 29346536: Issue 4155 - Created global csscomb config (Closed)

Patch Set: Fixed extra spaces and display property in sort order Created Sept. 16, 2016, 10:58 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 {
	Thomas Greiner 2016/09/16 12:47:03 I'd suggest adding "lines-between-rulesets". I'd suggest adding "lines-between-rulesets". juliandoucette 2016/09/16 16:32:27 This property was added after this config was crea Show quoted text On 2016/09/16 12:47:03, Thomas Greiner wrote: > I'd suggest adding "lines-between-rulesets". This property was added after this config was created. I agree.
	2 "remove-empty-rulesets": true,

	3 "always-semicolon": true,

	4 "color-case": "lower",

	5 "block-indent": " ",

	6 "color-shorthand": true,

	7 "element-case": "lower",

	8 "eof-newline": true,

	9 "leading-zero": true,

	10 "quotes": "double",

	11 "space-before-colon": "",

	12 "space-after-colon": " ",

	13 "space-before-combinator": " ",

	14 "space-after-combinator": " ",

	15 "space-between-declarations": "\n",

	16 "space-before-opening-brace": "\n",

	17 "space-after-opening-brace": "\n",

	18 "space-after-selector-delimiter": "\n",

	19 "space-before-selector-delimiter": "",

	20 "space-before-closing-brace": "\n",

	21 "strip-spaces": true,

	22 "tab-size": 2,

	23 "sort-order-fallback": "abc",

	24 "sort-order": [
	Thomas Greiner 2016/09/16 12:47:02 Our coding style only cares about the order of gro Our coding style only cares about the order of groups of properties, not of each individual property (see https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/...). We agreed on that to keep the ordering of properties simple but still somewhat organized. Therefore let's use CSScomb's other accepted value instead: "{Array} of arrays of rules for groups separation" (see https://github.com/csscomb/csscomb.js/blob/dev/doc/options.md#sort-order). juliandoucette 2016/09/16 16:32:27 I think you or I may be misinterpreting what {Arra Show quoted text On 2016/09/16 12:47:02, Thomas Greiner wrote: > Our coding style only cares about the order of groups of properties, not of each > individual property (see > https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/...). > We agreed on that to keep the ordering of properties simple but still somewhat > organized. > > Therefore let's use CSScomb's other accepted value instead: "{Array} of arrays > of rules for groups separation" (see > https://github.com/csscomb/csscomb.js/blob/dev/doc/options.md#sort-order). I think you or I may be misinterpreting what {Array} of array does here. The only thing that {Array} of arrays seems to do is automatically add newlines between the properties that are separated by array. (That is why I changed the value from Array:array to Array:string in my last changeset.) Thomas Greiner 2016/09/16 17:39:29 Ah, I see, my bad. Regarding using a linter or a Show quoted text On 2016/09/16 16:32:27, juliandoucette wrote: > On 2016/09/16 12:47:02, Thomas Greiner wrote: > > Our coding style only cares about the order of groups of properties, not of > each > > individual property (see > > > https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/...). > > We agreed on that to keep the ordering of properties simple but still somewhat > > organized. > > > > Therefore let's use CSScomb's other accepted value instead: "{Array} of arrays > > of rules for groups separation" (see > > https://github.com/csscomb/csscomb.js/blob/dev/doc/options.md#sort-order). > > I think you or I may be misinterpreting what {Array} of array does here. The > only thing that {Array} of arrays seems to do is automatically add newlines > between the properties that are separated by array. (That is why I changed the > value from Array:array to Array:string in my last changeset.) Ah, I see, my bad. Regarding using a linter or a beautifier, I'd prefer educating the developer on how code should look like with the help of a linter to avoid dependence on specific tools. This might especially be useful if you want to contribute to other projects where you don't have such tools in place. Anyway, if you still think that a beautifier provides enough value, maybe best to open a separate discussion since such a decision might affect other developers as well in the future.
	25 "display",

	26 "position",

	27 "z-index",

	28 "top",

	29 "right",

	30 "bottom",

	31 "left"

	32 "visibility",

	33 "float",

	34 "clear",

	35 "overflow",

	36 "overflow-x",

	37 "overflow-y",

	38 "-ms-overflow-x",
	Thomas Greiner 2016/09/16 12:47:02 Vendor-prefixed properties should be overridden by Vendor-prefixed properties should be overridden by their standardized versions, not the other way around. This is consistent with how we've been doing it so far and allows us to remove them later on without breaking anything. Note that I'm not even sure whether we should include vendor-prefixed properties in here. There might be situtations where changing the order could be necessary due to differing behaviors. But I'll leave that up to you. juliandoucette 2016/09/16 16:32:27 I agree. PS: Like I said, this is the default "y Show quoted text On 2016/09/16 12:47:02, Thomas Greiner wrote: > Vendor-prefixed properties should be overridden by their standardized versions, > not the other way around. This is consistent with how we've been doing it so far > and allows us to remove them later on without breaking anything. > > Note that I'm not even sure whether we should include vendor-prefixed properties > in here. There might be situtations where changing the order could be necessary > due to differing behaviors. But I'll leave that up to you. I agree. PS: Like I said, this is the default "yandex" config. I chose this config because it was the closest to ours. I did not change it until my last changeset where I removed the Array:arrays and display order. juliandoucette 2016/09/16 16:43:01 To clarify: I'm talking about the sort-order val Show quoted text On 2016/09/16 16:32:27, juliandoucette wrote: > On 2016/09/16 12:47:02, Thomas Greiner wrote: > > Vendor-prefixed properties should be overridden by their standardized > versions, > > not the other way around. This is consistent with how we've been doing it so > far > > and allows us to remove them later on without breaking anything. > > > > Note that I'm not even sure whether we should include vendor-prefixed > properties > > in here. There might be situtations where changing the order could be > necessary > > due to differing behaviors. But I'll leave that up to you. > > I agree. > > PS: Like I said, this is the default "yandex" config. I chose this config > because it was the closest to ours. I did not change it until my last changeset > where I removed the Array:arrays and display order. To clarify: I'm talking about the sort-order value. Not the whole config. See: https://github.com/csscomb/csscomb.js/tree/dev/config Thomas Greiner 2016/09/16 17:39:29 Yes, but I don't think we should enforce something Show quoted text On 2016/09/16 16:32:27, juliandoucette wrote: > On 2016/09/16 12:47:02, Thomas Greiner wrote: > > Vendor-prefixed properties should be overridden by their standardized > versions, > > not the other way around. This is consistent with how we've been doing it so > far > > and allows us to remove them later on without breaking anything. > > > > Note that I'm not even sure whether we should include vendor-prefixed > properties > > in here. There might be situtations where changing the order could be > necessary > > due to differing behaviors. But I'll leave that up to you. > > I agree. > > PS: Like I said, this is the default "yandex" config. I chose this config > because it was the closest to ours. I did not change it until my last changeset > where I removed the Array:arrays and display order. Yes, but I don't think we should enforce something yet that doesn't match our coding style. That could easily lead to confusion and inconsistencies. So thanks for making the changes. Generally, if you want to tackle it quickly and iterate on it over time, I guess starting from nothing and building it up piece by piece appears more reliable than doing it the other way around.
	39 "-ms-overflow-y",

	40 "-webkit-overflow-scrolling",

	41 "clip",

	42 "zoom",

	43 "flex-direction",

	44 "flex-order",

	45 "flex-pack",

	46 "flex-align"

	47 "-webkit-box-sizing",

	48 "-moz-box-sizing",

	49 "box-sizing",

	50 "width",

	51 "min-width",

	52 "max-width",

	53 "height",

	54 "min-height",

	55 "max-height",

	56 "margin",

	57 "margin-top",

	58 "margin-right",

	59 "margin-bottom",

	60 "margin-left",

	61 "padding",

	62 "padding-top",

	63 "padding-right",

	64 "padding-bottom",

	65 "padding-left"

	66 "table-layout",

	67 "empty-cells",

	68 "caption-side",

	69 "border-spacing",

	70 "border-collapse",

	71 "list-style",

	72 "list-style-position",

	73 "list-style-type",

	74 "list-style-image"

	75 "content",

	76 "quotes",

	77 "counter-reset",

	78 "counter-increment",

	79 "resize",

	80 "cursor",

	81 "-webkit-user-select",

	82 "-moz-user-select",

	83 "-ms-user-select",

	84 "user-select",

	85 "nav-index",

	86 "nav-up",

	87 "nav-right",

	88 "nav-down",

	89 "nav-left",

	90 "-webkit-transition",

	91 "-moz-transition",

	92 "-ms-transition",

	93 "-o-transition",

	94 "transition",

	95 "-webkit-transition-delay",

	96 "-moz-transition-delay",

	97 "-ms-transition-delay",

	98 "-o-transition-delay",

	99 "transition-delay",

	100 "-webkit-transition-timing-function",

	101 "-moz-transition-timing-function",

	102 "-ms-transition-timing-function",

	103 "-o-transition-timing-function",

	104 "transition-timing-function",

	105 "-webkit-transition-duration",

	106 "-moz-transition-duration",

	107 "-ms-transition-duration",

	108 "-o-transition-duration",

	109 "transition-duration",

	110 "-webkit-transition-property",

	111 "-moz-transition-property",

	112 "-ms-transition-property",

	113 "-o-transition-property",

	114 "transition-property",

	115 "-webkit-transform",

	116 "-moz-transform",

	117 "-ms-transform",

	118 "-o-transform",

	119 "transform",

	120 "-webkit-transform-origin",

	121 "-moz-transform-origin",

	122 "-ms-transform-origin",

	123 "-o-transform-origin",

	124 "transform-origin",

	125 "-webkit-animation",

	126 "-moz-animation",

	127 "-ms-animation",

	128 "-o-animation",

	129 "animation",

	130 "-webkit-animation-name",

	131 "-moz-animation-name",

	132 "-ms-animation-name",

	133 "-o-animation-name",

	134 "animation-name",

	135 "-webkit-animation-duration",

	136 "-moz-animation-duration",

	137 "-ms-animation-duration",

	138 "-o-animation-duration",

	139 "animation-duration",

	140 "-webkit-animation-play-state",

	141 "-moz-animation-play-state",

	142 "-ms-animation-play-state",

	143 "-o-animation-play-state",

	144 "animation-play-state",

	145 "-webkit-animation-timing-function",

	146 "-moz-animation-timing-function",

	147 "-ms-animation-timing-function",

	148 "-o-animation-timing-function",

	149 "animation-timing-function",

	150 "-webkit-animation-delay",

	151 "-moz-animation-delay",

	152 "-ms-animation-delay",

	153 "-o-animation-delay",

	154 "animation-delay",

	155 "-webkit-animation-iteration-count",

	156 "-moz-animation-iteration-count",

	157 "-ms-animation-iteration-count",

	158 "-o-animation-iteration-count",

	159 "animation-iteration-count",

	160 "-webkit-animation-iteration-count",

	161 "-moz-animation-iteration-count",

	162 "-ms-animation-iteration-count",

	163 "-o-animation-iteration-count",

	164 "animation-iteration-count",

	165 "-webkit-animation-direction",

	166 "-moz-animation-direction",

	167 "-ms-animation-direction",

	168 "-o-animation-direction",

	169 "animation-direction",

	170 "text-align",

	171 "-webkit-text-align-last",

	172 "-moz-text-align-last",

	173 "-ms-text-align-last",

	174 "text-align-last",

	175 "vertical-align",

	176 "white-space",

	177 "text-decoration",

	178 "text-emphasis",

	179 "text-emphasis-color",

	180 "text-emphasis-style",

	181 "text-emphasis-position",

	182 "text-indent",

	183 "-ms-text-justify",

	184 "text-justify",

	185 "text-transform",

	186 "letter-spacing",

	187 "word-spacing",

	188 "-ms-writing-mode",

	189 "text-outline",

	190 "text-transform",

	191 "text-wrap",

	192 "text-overflow",

	193 "-ms-text-overflow",

	194 "text-overflow-ellipsis",

	195 "text-overflow-mode",

	196 "-ms-word-wrap",

	197 "word-wrap",

	198 "word-break",

	199 "-ms-word-break",

	200 "-moz-tab-size",

	201 "-o-tab-size",

	202 "tab-size",

	203 "-webkit-hyphens",

	204 "-moz-hyphens",

	205 "hyphens",

	206 "pointer-events"

	207 "opacity",

	208 "filter:progid:DXImageTransform.Microsoft.Alpha(Opacity",
	Thomas Greiner 2016/09/16 12:47:02 I noticed that those IE-specific properties are sp I noticed that those IE-specific properties are spread all over while I didn't find the to-be-standardized "filter" property anywhere (see https://developer.mozilla.org/en-US/docs/Web/CSS/filter) with which we could group them together. Thomas Greiner 2016/09/16 12:47:03 Isn't the property name just "filter"? Isn't the property name just "filter"? juliandoucette 2016/09/16 16:32:27 See the "PS:" from my comment above. I think that Show quoted text On 2016/09/16 12:47:02, Thomas Greiner wrote: > I noticed that those IE-specific properties are spread all over while I didn't > find the to-be-standardized "filter" property anywhere (see > https://developer.mozilla.org/en-US/docs/Web/CSS/filter) with which we could > group them together. See the "PS:" from my comment above. I think that we should probably remove all proprietary properties from this list - Since we generally discourage their use - In favour of graceful degradation, by design juliandoucette 2016/09/16 16:43:01 In favour of progressive enhancement, by design* Show quoted text On 2016/09/16 16:32:27, juliandoucette wrote: > On 2016/09/16 12:47:02, Thomas Greiner wrote: > > I noticed that those IE-specific properties are spread all over while I didn't > > find the to-be-standardized "filter" property anywhere (see > > https://developer.mozilla.org/en-US/docs/Web/CSS/filter) with which we could > > group them together. > > See the "PS:" from my comment above. > > I think that we should probably remove all proprietary properties from this list > - Since we generally discourage their use > - In favour of graceful degradation, by design In favour of progressive enhancement, by design* Thomas Greiner 2016/09/16 17:39:30 Agreed. Show quoted text On 2016/09/16 16:43:01, juliandoucette wrote: > On 2016/09/16 16:32:27, juliandoucette wrote: > > On 2016/09/16 12:47:02, Thomas Greiner wrote: > > > I noticed that those IE-specific properties are spread all over while I > didn't > > > find the to-be-standardized "filter" property anywhere (see > > > https://developer.mozilla.org/en-US/docs/Web/CSS/filter) with which we could > > > group them together. > > > > See the "PS:" from my comment above. > > > > I think that we should probably remove all proprietary properties from this > list > > - Since we generally discourage their use > > - In favour of graceful degradation, by design > > In favour of progressive enhancement, by design* Agreed.
	209 "-ms-filter:\\'progid:DXImageTransform.Microsoft.Alpha",

	210 "-ms-interpolation-mode",

	211 "color",

	212 "border",

	213 "border-collapse",

	214 "border-width",

	215 "border-style",

	216 "border-color",

	217 "border-top",

	218 "border-top-width",

	219 "border-top-style",

	220 "border-top-color",

	221 "border-right",

	222 "border-right-width",

	223 "border-right-style",

	224 "border-right-color",

	225 "border-bottom",

	226 "border-bottom-width",

	227 "border-bottom-style",

	228 "border-bottom-color",

	229 "border-left",

	230 "border-left-width",

	231 "border-left-style",

	232 "border-left-color",

	233 "-webkit-border-radius",

	234 "-moz-border-radius",

	235 "border-radius",

	236 "-webkit-border-top-left-radius",

	237 "-moz-border-radius-topleft",

	238 "border-top-left-radius",

	239 "-webkit-border-top-right-radius",

	240 "-moz-border-radius-topright",

	241 "border-top-right-radius",

	242 "-webkit-border-bottom-right-radius",

	243 "-moz-border-radius-bottomright",

	244 "border-bottom-right-radius",

	245 "-webkit-border-bottom-left-radius",

	246 "-moz-border-radius-bottomleft",

	247 "border-bottom-left-radius",

	248 "-webkit-border-image",

	249 "-moz-border-image",

	250 "-o-border-image",

	251 "border-image",

	252 "-webkit-border-image-source",

	253 "-moz-border-image-source",

	254 "-o-border-image-source",

	255 "border-image-source",

	256 "-webkit-border-image-slice",

	257 "-moz-border-image-slice",

	258 "-o-border-image-slice",

	259 "border-image-slice",

	260 "-webkit-border-image-width",

	261 "-moz-border-image-width",

	262 "-o-border-image-width",

	263 "border-image-width",

	264 "-webkit-border-image-outset",

	265 "-moz-border-image-outset",

	266 "-o-border-image-outset",

	267 "border-image-outset",

	268 "-webkit-border-image-repeat",

	269 "-moz-border-image-repeat",

	270 "-o-border-image-repeat",

	271 "border-image-repeat",

	272 "outline",

	273 "outline-width",

	274 "outline-style",

	275 "outline-color",

	276 "outline-offset",

	277 "background",

	278 "filter:progid:DXImageTransform.Microsoft.AlphaImageLoader",

	279 "background-color",

	280 "background-image",

	281 "background-repeat",

	282 "background-attachment",

	283 "background-position",

	284 "background-position-x",

	285 "-ms-background-position-x",

	286 "background-position-y",

	287 "-ms-background-position-y",

	288 "-webkit-background-clip",

	289 "-moz-background-clip",

	290 "background-clip",

	291 "background-origin",

	292 "-webkit-background-size",

	293 "-moz-background-size",

	294 "-o-background-size",

	295 "background-size",

	296 "box-decoration-break",

	297 "-webkit-box-shadow",

	298 "-moz-box-shadow",

	299 "box-shadow",

	300 "-webkit-box-shadow",

	301 "-moz-box-shadow",

	302 "box-shadow",

	303 "-webkit-box-shadow",

	304 "-moz-box-shadow",

	305 "box-shadow",

	306 "-webkit-box-shadow",

	307 "-moz-box-shadow",

	308 "box-shadow",

	309 "filter:progid:DXImageTransform.Microsoft.gradient",

	310 "-ms-filter:\\'progid:DXImageTransform.Microsoft.gradient",

	311 "text-shadow"

	312 "font",

	313 "font-family",

	314 "font-size",

	315 "font-weight",

	316 "font-style",

	317 "font-variant",

	318 "font-size-adjust",

	319 "font-stretch",

	320 "font-effect",

	321 "font-emphasize",

	322 "font-emphasize-position",

	323 "font-emphasize-style",

	324 "font-smooth",

	325 "line-height"

	326 ]

	327 }

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »