eslintrc.json - Issue 29346539: Issue 3692 - Created global eslintrc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: eslintrc.json

Issue 29346539: Issue 3692 - Created global eslintrc (Closed)

Left Patch Set: removed rules covered by eslint:recommends Created Oct. 13, 2016, 2:03 p.m.

Right Patch Set: turned no-eq-null and no-unused-vars off Created Oct. 13, 2016, 2:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "extends": "eslint:recommended",	2 "extends": "eslint:recommended",

3 "rules": {	3 "rules": {

	4

4 /* MDN General practices */	5 /* MDN General practices */

5 "no-else-return": "warn",	6 "no-else-return": "error",

6 "no-alert": "warn",	7 "no-alert": "error",

7 "indent": ["warn", 2],	8 "indent": ["error", 2],

8 "valid-jsdoc": "warn",	9 "valid-jsdoc": "error",

9 "eol-last": "warn",	10 "eol-last": "error",

10 "vars-on-top": "off",	11 "vars-on-top": "off",
	Sebastian Noack 2017/02/01 19:50:34 According to the documentation, it seems vars-on-t According to the documentation, it seems vars-on-top isn't included in eslint:recommended. So might overriding this option be redundant?
	12

11 /* MDN Naming and formatting code */	13 /* MDN Naming and formatting code */

12 "no-trailing-spaces": "warn",	14 "no-trailing-spaces": "error",

13 "max-len": ["warn", 80],	15 "max-len": ["error", 80],

14 "brace-style": ["warn", "allman"],	16 "brace-style": ["error", "allman"],

	17

15 /* MDN JavaScript practices */	18 /* MDN JavaScript practices */

16 "no-eq-null": "off",

17 "consistent-return": "error",	19 "consistent-return": "error",

18 "no-array-constructor": "warn",	20 "no-array-constructor": "error",

19 "no-new-object": "warn",	21 "no-new-object": "error",

	22

20 /* ABP General */	23 /* ABP General */

21 "no-warning-comments": "warn",	24 "no-warning-comments": "error",

	25

22 /* Palant recommends */	26 /* Palant recommends */

23 "array-bracket-spacing": "warn",	27 "no-unused-vars": "off",
	Sebastian Noack 2017/02/01 19:50:34 I just noticed, instead of completely disabling no I just noticed, instead of completely disabling no-unused-vars, we could rather configure it to ignore global variables and function arguments, so that it still catches unused local variables, which I think have no legit use whatsoever: "no-unused-vars": ["error", {"vars": "local", "args": "none"}]
24 "arrow-spacing": "warn",	28 "array-bracket-spacing": "error",

25 "comma-spacing": "warn",	29 "arrow-spacing": "error",

26 "comma-style": "warn",	30 "comma-spacing": "error",

27 "computed-property-spacing": "warn",	31 "comma-style": "error",

28 "key-spacing": "warn",	32 "computed-property-spacing": "error",

29 "keyword-spacing": "warn",	33 "key-spacing": "error",

30 "new-parens": "warn",	34 "keyword-spacing": "error",

31 "func-call-spacing": "warn",	35 "new-parens": "error",

32 "no-var": "warn",	36 "func-call-spacing": "error",

33 "no-whitespace-before-property": "warn",	37 "no-var": "error",

34 "object-curly-spacing": "warn",	38 "no-whitespace-before-property": "error",

35 "operator-assignment": "warn",	39 "object-curly-spacing": "error",

36 "operator-linebreak": "warn",	40 "operator-assignment": "error",

37 "padded-blocks": ["warn", "never"],	41 "operator-linebreak": "error",

38 "prefer-rest-params": "warn",	42 "padded-blocks": ["error", "never"],

39 "prefer-spread": "warn",	43 "prefer-rest-params": "error",

40 "require-yield": "warn",	44 "prefer-spread": "error",

41 "quotes": ["warn", "double", {"avoidEscape": true}],	45 "require-yield": "error",
	Sebastian Noack 2017/02/01 19:50:34 It seems this is already included in eslint:recomm It seems this is already included in eslint:recommended. So might overriding this option be redundant?
42 "semi": "warn",	46 "quotes": ["error", "double", {"avoidEscape": true}],

43 "semi-spacing": "warn",	47 "semi": "error",

44 "space-before-function-paren": ["warn", "never"],	48 "semi-spacing": "error",

45 "space-in-parens": "warn",	49 "space-before-function-paren": ["error", "never"],

46 "space-infix-ops": "warn",	50 "space-in-parens": "error",

47 "space-unary-ops": "warn",	51 "space-infix-ops": "error",

48 "spaced-comment": "warn",	52 "space-unary-ops": "error",

49 "yield-star-spacing": "warn"	53 "spaced-comment": "error",

	54 "yield-star-spacing": "error"

50 }	55 }

51 }	56 }

LEFT	RIGHT