Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29346561: Issue 4160 - Return headers in AndroidWebRequest (Closed)

Created:
June 16, 2016, 11:04 a.m. by anton
Modified:
Sept. 15, 2016, 11:51 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4160 - Return headers in AndroidWebRequest

Patch Set 1 #

Total comments: 6

Patch Set 2 : Codestyle fixes #

Patch Set 3 : Codestyle fixes #2 #

Total comments: 3

Patch Set 4 : Codestyle fixes #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java View 1 2 3 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 8
anton
checking eachEntry.getKey() != null because "HTTP/1.1 200 OK" is parsed as header with null key ...
June 16, 2016, 11:09 a.m. (2016-06-16 11:09:44 UTC) #1
René Jeschke
https://codereview.adblockplus.org/29346561/diff/29346562/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java (right): https://codereview.adblockplus.org/29346561/diff/29346562/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode132 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:132: // headers This comment can be removed. https://codereview.adblockplus.org/29346561/diff/29346562/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode133 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:133: ...
July 12, 2016, 4:05 p.m. (2016-07-12 16:05:09 UTC) #2
anton
https://codereview.adblockplus.org/29346561/diff/29346562/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java (right): https://codereview.adblockplus.org/29346561/diff/29346562/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode132 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:132: // headers On 2016/07/12 16:05:09, René Jeschke wrote: > ...
July 13, 2016, 6:31 a.m. (2016-07-13 06:31:19 UTC) #3
anton
https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java (right): https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode135 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:135: for (Map.Entry<String, List<String>> eachEntry : connection.getHeaderFields().entrySet()) decided to fit ...
July 19, 2016, 9:50 a.m. (2016-07-19 09:50:30 UTC) #4
diegocarloslima
https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java (right): https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode135 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:135: for (Map.Entry<String, List<String>> eachEntry : connection.getHeaderFields().entrySet()) On 2016/07/19 09:50:30, ...
Sept. 6, 2016, 11:02 p.m. (2016-09-06 23:02:14 UTC) #5
anton
https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java (right): https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode135 libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java:135: for (Map.Entry<String, List<String>> eachEntry : connection.getHeaderFields().entrySet()) On 2016/09/06 23:02:14, ...
Sept. 8, 2016, 1:27 p.m. (2016-09-08 13:27:44 UTC) #6
diegocarloslima
On 2016/09/08 13:27:44, anton wrote: > https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java > File libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java > (right): > > https://codereview.adblockplus.org/29346561/diff/29348021/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java#newcode135 ...
Sept. 14, 2016, 11:06 p.m. (2016-09-14 23:06:46 UTC) #7
Felix Dahlke
Sept. 15, 2016, 9:03 a.m. (2016-09-15 09:03:10 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld