Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29346672: Issue 3141 - Add missing favicon and title to acceptableads.org (Closed)

Created:
June 20, 2016, 6:45 p.m. by juliandoucette
Modified:
July 8, 2016, 5:05 p.m.
Reviewers:
saroyanm
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3141 - Add missing favicon and title to acceptableads.org Repository: hg.adblockplus.org/web.acceptableads.org/

Patch Set 1 #

Patch Set 2 : Fixed favicon size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A static/favicon.ico View 1 Binary file 0 comments Download
M templates/minimal.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
June 20, 2016, 6:45 p.m. (2016-06-20 18:45:12 UTC) #1
juliandoucette
I know we are creating a new website that will make this issue obsolete. But, ...
June 20, 2016, 6:46 p.m. (2016-06-20 18:46:49 UTC) #2
saroyanm
According to the ticket the favicon size is 32px as on our other websites.
June 21, 2016, 4:55 p.m. (2016-06-21 16:55:52 UTC) #3
juliandoucette
On 2016/06/21 16:55:52, saroyanm wrote: > According to the ticket the favicon size is 32px ...
June 21, 2016, 6:45 p.m. (2016-06-21 18:45:00 UTC) #4
saroyanm
June 22, 2016, 6:28 a.m. (2016-06-22 06:28:03 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld