Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1033)

Issue 29346672: Issue 3141 - Add missing favicon and title to acceptableads.org (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by juliandoucette
Modified:
3 years, 4 months ago
Reviewers:
saroyanm
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 3141 - Add missing favicon and title to acceptableads.org Repository: hg.adblockplus.org/web.acceptableads.org/

Patch Set 1 #

Patch Set 2 : Fixed favicon size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A static/favicon.ico View 1 Binary file 0 comments Download
M templates/minimal.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
3 years, 4 months ago (2016-06-20 18:45:12 UTC) #1
juliandoucette
I know we are creating a new website that will make this issue obsolete. But, ...
3 years, 4 months ago (2016-06-20 18:46:49 UTC) #2
saroyanm
According to the ticket the favicon size is 32px as on our other websites.
3 years, 4 months ago (2016-06-21 16:55:52 UTC) #3
juliandoucette
On 2016/06/21 16:55:52, saroyanm wrote: > According to the ticket the favicon size is 32px ...
3 years, 4 months ago (2016-06-21 18:45:00 UTC) #4
saroyanm
3 years, 4 months ago (2016-06-22 06:28:03 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5