Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(282)

Issue 29346676: Issue 3766 - Restore default ABP bookmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by diegocarloslima
Modified:
3 years, 1 month ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3766 - Restore default ABP bookmarks This is a follow up of https://codereview.adblockplus.org/29341117/

Patch Set 1 #

Patch Set 2 : Including file removal #

Messages

Total messages: 4
diegocarloslima
This is a follow up of https://codereview.adblockplus.org/29341117/ (For technical reasons, I can't update the existing ...
3 years, 5 months ago (2016-06-20 21:17:40 UTC) #1
diegocarloslima
3 years, 5 months ago (2016-06-20 21:21:55 UTC) #2
anton
On 2016/06/20 21:21:55, diegocarloslima wrote: LGTM
3 years, 2 months ago (2016-09-30 07:07:40 UTC) #3
Felix Dahlke
3 years, 2 months ago (2016-09-30 07:24:22 UTC) #4
LGTM, but please make sure to use `hg mv` to rename the image files - otherwise
this won't show up as a rename in the history (Mercurial tracks renames, unlike
Git which does the similarity index thing).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5