Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29346676: Issue 3766 - Restore default ABP bookmarks (Closed)

Created:
June 20, 2016, 9:12 p.m. by diegocarloslima
Modified:
Oct. 19, 2016, 2:33 p.m.
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3766 - Restore default ABP bookmarks This is a follow up of https://codereview.adblockplus.org/29341117/

Patch Set 1 #

Patch Set 2 : Including file removal #

Messages

Total messages: 4
diegocarloslima
This is a follow up of https://codereview.adblockplus.org/29341117/ (For technical reasons, I can't update the existing ...
June 20, 2016, 9:17 p.m. (2016-06-20 21:17:40 UTC) #1
diegocarloslima
June 20, 2016, 9:21 p.m. (2016-06-20 21:21:55 UTC) #2
anton
On 2016/06/20 21:21:55, diegocarloslima wrote: LGTM
Sept. 30, 2016, 7:07 a.m. (2016-09-30 07:07:40 UTC) #3
Felix Dahlke
Sept. 30, 2016, 7:24 a.m. (2016-09-30 07:24:22 UTC) #4
LGTM, but please make sure to use `hg mv` to rename the image files - otherwise
this won't show up as a rename in the history (Mercurial tracks renames, unlike
Git which does the similarity index thing).

Powered by Google App Engine
This is Rietveld