Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packager.py

Issue 29347006: Issue 4192 - getBuildNum must return a string (Closed)
Patch Set: Created June 24, 2016, 10:07 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packager.py
diff --git a/packager.py b/packager.py
index ca4415b67f5ac4945e53d96dbc9edd6dafd75e32..5c896feb406961cd3b87de70929da53fe0081ad7 100644
--- a/packager.py
+++ b/packager.py
@@ -45,7 +45,7 @@ def getBuildNum(baseDir):
return re.sub(r'\D', '', result)
elif Git().istype(baseDir):
result = subprocess.check_output(['git', 'rev-list', 'HEAD'], cwd=baseDir)
- return len(result.splitlines())
+ return str(len(result.splitlines()))
except subprocess.CalledProcessError:
pass
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld