Issue 1727 - Prevent circumvention via WebSocket

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 332 matching lines @@
   var observer = new MutationObserver(function()
   {
     if (style.parentNode != parentNode)
       parentNode.appendChild(style);
   });
 
   observer.observe(parentNode, {childList: true});
   return observer;
 }
 
-function injectJS(f)
-{
-  var args = JSON.stringify(Array.prototype.slice.call(arguments, 1));
-  args = args.substring(1, args.length - 1);
-  var codeString = "(" + f.toString() + ")(" + args + ");";
-
+function runInPage(fn, arg)
+{
   var script = document.createElement("script");
+  script.type = "application/javascript";
   script.async = false;
-  script.textContent = codeString;
+  script.textContent = "(" + fn + ")(" + JSON.stringify(arg) + ");";
   document.documentElement.appendChild(script);
   document.documentElement.removeChild(script);
 }
 
 function protectStyleSheet(document, style)
 {
   style.id = id;
 
-  var protector = function(id)
+  runInPage(function(id)
   {
     var style = document.getElementById(id) ||
                 document.documentElement.shadowRoot.getElementById(id);
     style.removeAttribute("id");
 
-    var i;
     var disableables = [style, style.sheet];
-    for (i = 0; i < disableables.length; i += 1)
+    for (var i = 0; i < disableables.length; i++)
       Object.defineProperty(disableables[i], "disabled",
                             {value: false, enumerable: true});
 
-    var methods = ["deleteRule", "removeRule"];
-    for (i = 0; i < methods.length; i += 1)
-    {
-      if (methods[i] in CSSStyleSheet.prototype)
-      {
-        (function(method)
-        {
-          var original = CSSStyleSheet.prototype[method];
-          CSSStyleSheet.prototype[method] = function(index)
-          {
-            if (this != style.sheet)
-              original.call(this, index);
-          };
-        }(methods[i]));
-      }
-    }
-  };
-
-  injectJS(protector, id);
+    ["deleteRule", "removeRule"].forEach(function(method)
+    {
+      var original = CSSStyleSheet.prototype[method];
+      CSSStyleSheet.prototype[method] = function(index)
+      {
+        if (this != style.sheet)
+          original.call(this, index);
+      };
+    });
+  }, id);
 }
 
 // Neither Chrome[1] nor Safari allow us to intercept WebSockets, and therefore
 // some ad networks are misusing them as a way to serve adverts and circumvent
 // us. As a workaround we wrap WebSocket, preventing blocked WebSocket
 // connections from being opened.
 // [1] - https://bugs.chromium.org/p/chromium/issues/detail?id=129353
 function wrapWebSocket()
 {
   if (typeof WebSocket == "undefined")
     return;
 
   var eventName = "abpws-" + id;
 
   document.addEventListener(eventName, function(event)
   {
     ext.backgroundPage.sendMessage({
       type: "websocket-request",
       url: event.detail.url
     }, function (block)
     {
       document.dispatchEvent(
         new CustomEvent(eventName + "-" + event.detail.url, {detail: block})
       );
     });
   });
 
-  function wrapper(eventName)
+  runInPage(function(eventName)
   {
     // As far as possible we must track everything we use that could be
     // sabotaged by the website later in order to circumvent us.
     var RealWebSocket = WebSocket;
-    var closeWebSocket = RealWebSocket.prototype.close;
-    var document = window.document;
-    var addEventListener = document.addEventListener;
-    var removeEventListener = document.removeEventListener;
-    var dispatchEvent = document.dispatchEvent;
+    var closeWebSocket = Function.prototype.call.bind(RealWebSocket.prototype.close);
+    var addEventListener = document.addEventListener.bind(document);
+    var removeEventListener = document.removeEventListener.bind(document);
+    var dispatchEvent = document.dispatchEvent.bind(document);
     var CustomEvent = window.CustomEvent;
-    var bind = Function.prototype.bind;
-    var call = Function.prototype.call;
-
-    function checkRequest(url, protocols, callback)
+
+    function checkRequest(url, callback)
     {
       var incomingEventName = eventName + "-" + url;
       function listener(event)
       {
         callback(event.detail);
-        call.bind(removeEventListener)(document, incomingEventName, listener);
-      }
-      call.bind(addEventListener)(document, incomingEventName, listener);
-
-      call.bind(dispatchEvent)(document, new CustomEvent(eventName, {
-        detail: {url: url, protocols: protocols}
+        removeEventListener(incomingEventName, listener);
+      }
+      addEventListener(incomingEventName, listener);
+
+      dispatchEvent(new CustomEvent(eventName, {
+        detail: {url: url}
       }));
     }
 
-    WebSocket = function(url, protocols)
-    {
+    WebSocket = function WrappedWebSocket(url, protocols)
+    {
+      // Throw correct exceptions if the constructor is used improperly.
+      if (!(this instanceof WrappedWebSocket)) return RealWebSocket();
+      if (arguments.length < 1) return new RealWebSocket();
+
       var websocket = new RealWebSocket(url, protocols);
 
-      checkRequest(url, protocols, function(blocked)
+      checkRequest(websocket.url, function(blocked)
       {
         if (blocked)
-          call.bind(closeWebSocket)(websocket);
+          closeWebSocket(websocket);
       });
 
       return websocket;
-    };
+    }.bind();
+
     Object.defineProperties(WebSocket, {
-      CONNECTING: {value: 0, enumerable: true},
-      OPEN: {value: 1, enumerable: true},
-      CLOSING: {value: 2, enumerable: true},
-      CLOSED: {value: 3, enumerable: true}
+      CONNECTING: {value: RealWebSocket.CONNECTING, enumerable: true},
+      OPEN: {value: RealWebSocket.OPEN, enumerable: true},
+      CLOSING: {value: RealWebSocket.CLOSING, enumerable: true},
+      CLOSED: {value: RealWebSocket.CLOSED, enumerable: true},
+      prototype: {value: RealWebSocket.prototype}
     });
-    WebSocket.prototype = RealWebSocket.prototype;
+
     RealWebSocket.prototype.constructor = WebSocket;
-  }
-
-  injectJS(wrapper, eventName);
+  }, eventName);
 }
 
 function init(document)
 {
   var shadow = null;
   var style = null;
   var observer = null;
   var tracer = null;
 
   wrapWebSocket();
@@ skipping 161 matching lines @@
   }, true);
 
   return updateStylesheet;
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   window.updateStylesheet = init(document);
 }