Issue 1727 - Prevent circumvention via WebSocket

lib/requestBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 139 matching lines @@
 FilterNotifier.on("subscription.removed", onFilterChange);
 FilterNotifier.on("subscription.updated", onFilterChange);
 FilterNotifier.on("subscription.disabled", arg => onFilterChange(arg, true));
 FilterNotifier.on("filter.added", onFilterChange);
 FilterNotifier.on("filter.removed", onFilterChange);
 FilterNotifier.on("filter.disabled", arg => onFilterChange(arg, true));
 FilterNotifier.on("load", onFilterChange);
 
 port.on("websocket-request", function(msg, sender)
 {
-  var results = ext.webRequest.onBeforeRequest._dispatch(

[Sebastian Noack, 2016/08/08 16:42:55]

Nit: We prefer block scoping (i.e. "let") in modules processed by jsHydra.
Personally, I would not create a variable here in the first place.

[kzar, 2016/08/08 18:19:06]

Done.

+  return ext.webRequest.onBeforeRequest._dispatch(
     new URL(msg.url),
     "OTHER",
     sender.page,
     sender.frame
-  );
-  return results.indexOf(false) != -1;
+  ).indexOf(false) != -1;
 });