Issue 1727 - Prevent circumvention via WebSocket

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 436 matching lines @@
       var websocket = new RealWebSocket(url, protocols);
 
       checkRequest(websocket.url, function(blocked)
       {
         if (blocked)
           closeWebSocket(websocket);
       });
 
       return websocket;
     }.bind();
+
     Object.defineProperties(WebSocket, {
-      CONNECTING: {value: 0, enumerable: true},

[Sebastian Noack, 2016/08/10 16:15:39]

Still not a reason to hard-code the values:

  Object.defineProperties(WebSocket, {
    CONNECTING: {value: RealWebSocket.CONNECTING, ...

Also, the blank lines above and below helped the readability.

[kzar, 2016/08/10 16:20:07]

Added the blank lines back, sorry didn't mean to remove those.

Do you insist about the values? I'd rather keep it like this since it looks
nicer and they're hardly going to change. (If the values change the names could
just as well change too.)

-      OPEN: {value: 1, enumerable: true},
-      CLOSING: {value: 2, enumerable: true},
-      CLOSED: {value: 3, enumerable: true},
+      CONNECTING: {value: RealWebSocket.CONNECTING, enumerable: true},
+      OPEN: {value: RealWebSocket.OPEN, enumerable: true},
+      CLOSING: {value: RealWebSocket.CLOSING, enumerable: true},
+      CLOSED: {value: RealWebSocket.CLOSED, enumerable: true},
       prototype: {value: RealWebSocket.prototype}
     });
+
     RealWebSocket.prototype.constructor = WebSocket;
   }, eventName);
 }
 
 function init(document)
 {
   var shadow = null;
   var style = null;
   var observer = null;
   var tracer = null;
@@ skipping 163 matching lines @@
   }, true);
 
   return updateStylesheet;
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   window.updateStylesheet = init(document);
 }