Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(592)

Issue 29347257: Issue 3997 - Wrong information about employees on Eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by juliandoucette
Modified:
3 years, 5 months ago
CC:
Thomas Greiner, Vasily Kuznetsov, Jon Sonesen
Visibility:
Public.

Description

Issue 3997 - Wrong information about employees on Eyeo.com Repository: hg.adblockplus.org/web.eyeo.com/

Patch Set 1 #

Patch Set 2 : Separated country and flag global variables #

Patch Set 3 : Implemented EU exception and removed additional global field #

Patch Set 4 : Changed approach to check against non_countries list instead of hard coded non_countries inside cou… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
A filters/countries_length.py View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M includes/jobs/why.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A includes/size-of-countries.tmpl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21
juliandoucette
3 years, 11 months ago (2016-07-02 18:24:39 UTC) #1
saroyanm
No LGTM After discussion with HR department employees should decide on the flags individually, so ...
3 years, 11 months ago (2016-07-07 09:04:36 UTC) #2
saroyanm
NOT LGTM
3 years, 11 months ago (2016-07-07 09:06:22 UTC) #3
Sebastian Noack
Yes, it's up to our team members which country they want to identify with (on ...
3 years, 11 months ago (2016-07-07 18:42:58 UTC) #4
saroyanm
On 2016/07/07 18:42:58, Sebastian Noack wrote: > Yes, it's up to our team members which ...
3 years, 11 months ago (2016-07-08 07:53:27 UTC) #5
juliandoucette
On 2016/07/08 07:53:27, saroyanm wrote: > On 2016/07/07 18:42:58, Sebastian Noack wrote: > > Yes, ...
3 years, 11 months ago (2016-07-08 16:45:00 UTC) #6
saroyanm
On 2016/07/08 16:45:00, juliandoucette wrote: > On 2016/07/08 07:53:27, saroyanm wrote: > > On 2016/07/07 ...
3 years, 11 months ago (2016-07-11 09:35:55 UTC) #7
Sebastian Noack
On 2016/07/11 09:35:55, saroyanm wrote: > On 2016/07/08 16:45:00, juliandoucette wrote: > > On 2016/07/08 ...
3 years, 11 months ago (2016-07-11 15:22:57 UTC) #8
saroyanm
On 2016/07/11 15:22:57, Sebastian Noack wrote: > On 2016/07/11 09:35:55, saroyanm wrote: > > On ...
3 years, 11 months ago (2016-07-11 15:32:01 UTC) #9
Sebastian Noack
On 2016/07/11 15:32:01, saroyanm wrote: > On 2016/07/11 15:22:57, Sebastian Noack wrote: > > On ...
3 years, 11 months ago (2016-07-11 15:48:18 UTC) #10
saroyanm
On 2016/07/11 15:48:18, Sebastian Noack wrote: > On 2016/07/11 15:32:01, saroyanm wrote: > > On ...
3 years, 11 months ago (2016-07-11 16:35:34 UTC) #11
juliandoucette
Done deal.
3 years, 11 months ago (2016-07-12 14:49:27 UTC) #12
juliandoucette
On 2016/07/12 14:49:27, juliandoucette wrote: > Done deal. Shit... That's not right. If we exclude ...
3 years, 11 months ago (2016-07-12 14:51:37 UTC) #13
juliandoucette
On 2016/07/12 14:51:37, juliandoucette wrote: > On 2016/07/12 14:49:27, juliandoucette wrote: > > Done deal. ...
3 years, 11 months ago (2016-07-12 18:37:45 UTC) #14
juliandoucette
On 2016/07/12 18:37:45, juliandoucette wrote: > On 2016/07/12 14:51:37, juliandoucette wrote: > > On 2016/07/12 ...
3 years, 11 months ago (2016-07-12 18:39:05 UTC) #15
juliandoucette
This is ready for review.
3 years, 10 months ago (2016-07-28 21:57:22 UTC) #16
juliandoucette
> This is ready for review. This is no longer valid as "eu" was changed ...
3 years, 8 months ago (2016-09-22 14:02:29 UTC) #17
Sebastian Noack
On 2016/09/22 14:02:29, juliandoucette wrote: > Also, we shouldn't use includes/globals.tmpl. That's what globals/ are ...
3 years, 8 months ago (2016-09-22 14:09:52 UTC) #18
juliandoucette
On 2016/09/22 14:09:52, Sebastian Noack wrote: > On 2016/09/22 14:02:29, juliandoucette wrote: > > Also, ...
3 years, 8 months ago (2016-09-22 17:27:23 UTC) #19
juliandoucette
Updated. I encountered errors on the team page when converting includes/globals to globals/people so I ...
3 years, 8 months ago (2016-10-10 20:27:49 UTC) #20
juliandoucette
3 years, 5 months ago (2017-01-04 20:16:47 UTC) #21
On 2016/10/10 20:27:49, juliandoucette wrote:
> Updated.
> 
> I encountered errors on the team page when converting includes/globals to
> globals/people so I decided to leave that change out of this review. 
> 
> This should be a quick one.

I am going to implement this differently, based on a discussion with Maren.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5