filters/countries_length.py - Issue 29347257: Issue 3997 - Wrong information about employees on Eyeo.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: filters/countries_length.py

Issue 29347257: Issue 3997 - Wrong information about employees on Eyeo.com (Closed)

Patch Set: Changed approach to check against non_countries list instead of hard coded non_countries inside cou… Created Oct. 10, 2016, 8:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1

	2 non_countries = ["earth"];

	3

	4 def countries_length(people):

	5 return len(({flag for _, flag, _, _, _, _ in people if flag not in non_count ries}))

OLD	NEW

« no previous file with comments | « no previous file | includes/jobs/why.md » ('j') | no next file with comments »