Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: filters/countries_length.py
Issue
29347257
:
Issue 3997 - Wrong information about employees on Eyeo.com (Closed)
Left Patch Set: Implemented EU exception and removed additional global field
Created July 12, 2016, 2:48 p.m.
Right Patch Set: Changed approach to check against non_countries list instead of hard coded non_countries inside cou…
Created Oct. 10, 2016, 8:25 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Separated country and flag global variables
Patch Set 3: Implemented EU exception and removed additional global field
Patch Set 4: Changed approach to check against non_countries list instead of hard coded non_countries inside cou…
Right:
Patch Set 1: None
Patch Set 2: Separated country and flag global variables
Patch Set 3: Implemented EU exception and removed additional global field
Patch Set 4: Changed approach to check against non_countries list instead of hard coded non_countries inside cou…
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
filters/countries_length.py
includes/jobs/why.md
includes/size-of-countries.tmpl
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« no previous file
|
includes/jobs/why.md »
('j') |
no next file with change/comment »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
2
non_countries = ["earth"];
3
4
def countries_length(people):
5
return len(({flag for _, flag, _, _, _, _ in people if flag not in non_count ries}))
LEFT
RIGHT
« no previous file
|
includes/jobs/why.md »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29347257: Issue 3997 - Wrong information about employees on Eyeo.com (Closed)
Created July 2, 2016, 6:24 p.m. by juliandoucette
Modified Jan. 4, 2017, 8:16 p.m.
Reviewers: saroyanm, Sebastian Noack
Base URL:
Comments: 0
This is Rietveld