Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 60 matching lines @@
     }
 
     triggerEvent(this.ptr, eventName, args);
   }
 
   public void triggerEvent(final String eventName)
   {
     triggerEvent(this.ptr, eventName, null);
   }
 
+  public void setFileSystem(FileSystem fileSystem)

[anton, 2016/12/13 09:41:36]

Just noting that it's extremely bad for performance to use this file system as
all read/write routines are inefficient because of stream to string copying to
pass JNI layer. Use 'setDefaultFile' for better performance. Setting test file
system if more efficient

[diegocarloslima, 2017/04/27 12:22:40]

I do agree that reading all the file and passing it as string is really
inefficient and can even cause OOM error. Couldn't we just pass the file path
(or even a path for a copy of the file itself) and have it read by the c++ side?

[anton, 2017/04/28 08:25:45]

Then it removes the sense of providing the impl at all.
eg. how will override returning file content in Java code?
I believe the hierarchy and android impl is okay but i've added a comment to
AndroidFileSystem class about it

+  {
+    setFileSystem(this.ptr, fileSystem.ptr);
+  }
+
   public void setDefaultFileSystem(final String basePath)
   {
     setDefaultFileSystem(this.ptr, basePath);
   }
 
   public void setDefaultLogSystem()
   {
     setDefaultLogSystem(this.ptr);
   }
 
@@ skipping 54 matching lines @@
   private final static native long ctor(AppInfo appInfo);
 
   private final static native void setEventCallback(long ptr, String eventName, long callback);
 
   private final static native void removeEventCallback(long ptr, String eventName);
 
   private final static native JsValue evaluate(long ptr, String source, String filename);
 
   private final static native void triggerEvent(long ptr, String eventName, long[] args);
 
+  private final static native void setFileSystem(long ptr, long fileSystemPtr);
+
   private final static native void setDefaultFileSystem(long ptr, String basePath);
 
   private final static native void setLogSystem(long ptr, long logSystemPtr);
 
   private final static native void setDefaultLogSystem(long ptr);
 
   private final static native void setWebRequest(long ptr, long webRequestPtr);
 
   private final static native void setDefaultWebRequest(long ptr);
 
   private final static native JsValue newValue(long ptr, long value);
 
   private final static native JsValue newValue(long ptr, boolean value);
 
   private final static native JsValue newValue(long ptr, String value);
 
   private final static native void dtor(long ptr);
 }