Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
 import org.adblockplus.libadblockplus.FilterEngine;
 import org.adblockplus.libadblockplus.LazyWebRequest;
 
 public abstract class FilterEngineGenericTest extends BaseJsTest
 {
-    protected FilterEngine filterEngine;
+  protected FilterEngine filterEngine;
 
-    @Override
-    protected void setUp() throws Exception
-    {
-        super.setUp();
+  @Override
+  protected void setUp() throws Exception
+  {
+    super.setUp();
 
-        jsEngine.setWebRequest(new LazyWebRequest());
-        jsEngine.setDefaultLogSystem();
-        jsEngine.setFileSystem(new LazyFileSystem());
+    jsEngine.setWebRequest(new LazyWebRequest());
+    jsEngine.setDefaultLogSystem();
+    jsEngine.setFileSystem(new LazyFileSystem());

[anton, 2016/12/13 09:41:36]

BTW i'm following "Lazy.." name rule practice but actually it's not Lazy, it's
Stub or smth.. Should not we change it everywhere?

[diegocarloslima, 2017/04/27 12:22:40]

Yeah, I do agree we should rename it, if it makes more sense. You can change the
'LazyFileSystem' in this issue and then create a follow up issue to change the
others.

[anton, 2017/04/28 08:25:45]

Done.

 
-        filterEngine = new FilterEngine(jsEngine);
-    }
+    filterEngine = new FilterEngine(jsEngine);
+  }
 }