Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.tests;
 
 import org.adblockplus.libadblockplus.FileSystem;
 
 public class LazyFileSystem extends FileSystem
 {
-    private boolean patternsIniExists = true;

[René Jeschke, 2016/07/12 16:00:42]

Is there a point in making this flag modifiable _after_ creation? If not, then I
would prefer having this flag being set by a ctor, and let the default ctor set
it to 'false'.

[anton, 2016/07/13 06:41:13]

It's unknown if we need to change it after creation during object lifetime. I've
been thinking about introducing it as ctor argument but i decided that later we
may need other variables to be set that's why i decided not to introduce this
limitation before we know we need it for sure. For current requirements we can
definitely do it if you insist. Do you?

+  private boolean patternsIniExists = true;
 
-    public boolean isPatternsIniExists()
+  public boolean isPatternsIniExists()
+  {
+    return patternsIniExists;
+  }
+
+  public void setPatternsIniExists(boolean patternsIniExists)
+  {
+    this.patternsIniExists = patternsIniExists;
+  }
+
+  @Override
+  public String read(String path)
+  {
+    if (path.equals("patterns.ini"))
     {
-        return patternsIniExists;
+      return "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
     }
+    else if (path.equals("prefs.json"))
+    {
+      return "{}";
+    }
+    else
+    {
+      return "";
+    }
+  }
 
-    public void setPatternsIniExists(boolean patternsIniExists)
-    {
-        this.patternsIniExists = patternsIniExists;
-    }
+  @Override
+  public void write(String path, String data)
+  {
 
-    @Override
-    public String read(String path)
-    {
-        if (path.equals("patterns.ini"))
-            return "# Adblock Plus preferences\n[Subscription]\nurl=~fl~";
-        else if (path.equals("prefs.json"))
-            return "{}";
-        else
-            return "";
-    }
+  }
 
-    @Override
-    public void write(String path, String data)
-    {
+  @Override
+  public void move(String fromPath, String toPath)
+  {
 
-    }
+  }
 
-    @Override
-    public void move(String fromPath, String toPath)
-    {
+  @Override
+  public void remove(String path)
+  {
 
-    }
+  }
 
-    @Override
-    public void remove(String path)
-    {
+  @Override
+  public StatResult stat(String path)
+  {
+    return path.equals("patterns.ini")
+      ? new StatResult(patternsIniExists, false, true, 0)
+      : new StatResult(false, false, false, 0);
+  }
 
-    }
-
-    @Override
-    public StatResult stat(String path)
-    {
-        return path.equals("patterns.ini")
-            ? new StatResult(patternsIniExists, false, true, 0)
-            : new StatResult(false, false, false, 0);
-    }
-
-    @Override
-    public String resolve(String path)
-    {
-        return path;
-    }
+  @Override
+  public String resolve(String path)
+  {
+    return path;
+  }
 }