Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java

Index: libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java
diff --git a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java
index 7a651a7e1ab728a8f994b7788f7ff47fd3407371..50ceeca9b69756e012879cf12e0e25ef24917d5c 100644
--- a/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java
+++ b/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/LazyFileSystem.java
@@ -21,6 +21,18 @@ import org.adblockplus.libadblockplus.FileSystem;
 
 public class LazyFileSystem extends FileSystem
 {
+    private boolean patternsIniExists = true;

[René Jeschke, 2016/07/12 16:00:42]

Is there a point in making this flag modifiable _after_ creation? If not, then I
would prefer having this flag being set by a ctor, and let the default ctor set
it to 'false'.

[anton, 2016/07/13 06:41:13]

It's unknown if we need to change it after creation during object lifetime. I've
been thinking about introducing it as ctor argument but i decided that later we
may need other variables to be set that's why i decided not to introduce this
limitation before we know we need it for sure. For current requirements we can
definitely do it if you insist. Do you?

+
+    public boolean isPatternsIniExists()
+    {
+        return patternsIniExists;
+    }
+
+    public void setPatternsIniExists(boolean patternsIniExists)
+    {
+        this.patternsIniExists = patternsIniExists;
+    }
+
     @Override
     public String read(String path)
     {
@@ -54,7 +66,7 @@ public class LazyFileSystem extends FileSystem
     public StatResult stat(String path)
     {
         return path.equals("patterns.ini")
-            ? new StatResult(true, false, true, 0)
+            ? new StatResult(patternsIniExists, false, true, 0)
             : new StatResult(false, false, false, 0);
     }