Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
index c889cd81d8727718d1ba70008119e5bd54447483..80eb014893f46bd621ccd9377f0ac889e61a491d 100644
--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/JsEngine.java
@@ -78,6 +78,11 @@ public final class JsEngine implements Disposable
     triggerEvent(this.ptr, eventName, null);
   }
 
+  public void setFileSystem(FileSystem fileSystem)

[anton, 2016/12/13 09:41:36]

Just noting that it's extremely bad for performance to use this file system as
all read/write routines are inefficient because of stream to string copying to
pass JNI layer. Use 'setDefaultFile' for better performance. Setting test file
system if more efficient

[diegocarloslima, 2017/04/27 12:22:40]

I do agree that reading all the file and passing it as string is really
inefficient and can even cause OOM error. Couldn't we just pass the file path
(or even a path for a copy of the file itself) and have it read by the c++ side?

[anton, 2017/04/28 08:25:45]

Then it removes the sense of providing the impl at all.
eg. how will override returning file content in Java code?
I believe the hierarchy and android impl is okay but i've added a comment to
AndroidFileSystem class about it

+  {
+    setFileSystem(this.ptr, fileSystem.ptr);
+  }
+
   public void setDefaultFileSystem(final String basePath)
   {
     setDefaultFileSystem(this.ptr, basePath);
@@ -152,6 +157,8 @@ public final class JsEngine implements Disposable
 
   private final static native void triggerEvent(long ptr, String eventName, long[] args);
 
+  private final static native void setFileSystem(long ptr, long fileSystemPtr);
+
   private final static native void setDefaultFileSystem(long ptr, String basePath);
 
   private final static native void setLogSystem(long ptr, long logSystemPtr);