Issue 4037 - Update the user numbers on adblockplus.org

Issue 4037 - Update the user numbers on adblockplus.org

[juliandoucette, 2016-07-08 17:38:08]

@tamara can you verify that we are translating our user numbers correctly?

We are currently formatting them like so "<fix>100</fix> million active
devices". This implies that "100" will not be translated and "million active
devices" will always be translated and appear after "100".

[tamara, 2016-07-08 18:03:42]

On 2016/07/08 17:38:08, juliandoucette wrote:
> @tamara can you verify that we are translating our user numbers correctly?
> 
> We are currently formatting them like so "<fix>100</fix> million active
> devices". This implies that "100" will not be translated and "million active
> devices" will always be translated and appear after "100".

I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are expressed
differently than in other languages: "Chinese forms numbers between 10,000 and
100,000,000 based off of how many tens of thousands they have." For this reason,
instead of writing the digits 100 or 10 as such in the Chinese translations,
they have been expressed as 1 + the amount of thousands needed to make either
100 million or 10 million in Chinese characters. Therefore we cannot fix 100 and
10.  :(  Not sure if this makes sense? :-/

[juliandoucette, 2016-07-08 18:07:29]

On 2016/07/08 18:03:42, tamara wrote:
> On 2016/07/08 17:38:08, juliandoucette wrote:
> > @tamara can you verify that we are translating our user numbers correctly?
> > 
> > We are currently formatting them like so "<fix>100</fix> million active
> > devices". This implies that "100" will not be translated and "million active
> > devices" will always be translated and appear after "100".
> 
> I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are
expressed
> differently than in other languages: "Chinese forms numbers between 10,000 and
> 100,000,000 based off of how many tens of thousands they have." For this
reason,
> instead of writing the digits 100 or 10 as such in the Chinese translations,
> they have been expressed as 1 + the amount of thousands needed to make either
> 100 million or 10 million in Chinese characters. Therefore we cannot fix 100
and
> 10.  :(  Not sure if this makes sense? :-/

I had that hunch ;)

Can you create another ticket about this issue if it exists in other places on
our websites too @tamara?

[tamara, 2016-07-08 18:08:42]

On 2016/07/08 18:07:29, juliandoucette wrote:
> On 2016/07/08 18:03:42, tamara wrote:
> > On 2016/07/08 17:38:08, juliandoucette wrote:
> > > @tamara can you verify that we are translating our user numbers correctly?
> > > 
> > > We are currently formatting them like so "<fix>100</fix> million active
> > > devices". This implies that "100" will not be translated and "million
active
> > > devices" will always be translated and appear after "100".
> > 
> > I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are
> expressed
> > differently than in other languages: "Chinese forms numbers between 10,000
and
> > 100,000,000 based off of how many tens of thousands they have." For this
> reason,
> > instead of writing the digits 100 or 10 as such in the Chinese translations,
> > they have been expressed as 1 + the amount of thousands needed to make
either
> > 100 million or 10 million in Chinese characters. Therefore we cannot fix 100
> and
> > 10.  :(  Not sure if this makes sense? :-/
> 
> I had that hunch ;)
> 
> Can you create another ticket about this issue if it exists in other places on
> our websites too @tamara?

Good hunch!  ;)  I'll have a look and get on it next week, if that's ok.  ^^

[juliandoucette, 2016-07-08 18:48:28]

On 2016/07/08 18:08:42, tamara wrote:
> On 2016/07/08 18:07:29, juliandoucette wrote:
> > On 2016/07/08 18:03:42, tamara wrote:
> > > On 2016/07/08 17:38:08, juliandoucette wrote:
> > > > @tamara can you verify that we are translating our user numbers
correctly?
> > > > 
> > > > We are currently formatting them like so "<fix>100</fix> million active
> > > > devices". This implies that "100" will not be translated and "million
> active
> > > > devices" will always be translated and appear after "100".
> > > 
> > > I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are
> > expressed
> > > differently than in other languages: "Chinese forms numbers between 10,000
> and
> > > 100,000,000 based off of how many tens of thousands they have." For this
> > reason,
> > > instead of writing the digits 100 or 10 as such in the Chinese
translations,
> > > they have been expressed as 1 + the amount of thousands needed to make
> either
> > > 100 million or 10 million in Chinese characters. Therefore we cannot fix
100
> > and
> > > 10.  :(  Not sure if this makes sense? :-/
> > 
> > I had that hunch ;)
> > 
> > Can you create another ticket about this issue if it exists in other places
on
> > our websites too @tamara?
> 
> Good hunch!  ;)  I'll have a look and get on it next week, if that's ok.  ^^

Great!

Patch updated.

[saroyanm, 2016-07-11 08:50:24]

On 2016/07/08 18:03:42, tamara wrote:
> On 2016/07/08 17:38:08, juliandoucette wrote:
> > @tamara can you verify that we are translating our user numbers correctly?
> > 
> > We are currently formatting them like so "<fix>100</fix> million active
> > devices". This implies that "100" will not be translated and "million active
> > devices" will always be translated and appear after "100".
> 
> I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are
expressed
> differently than in other languages: "Chinese forms numbers between 10,000 and
> 100,000,000 based off of how many tens of thousands they have." For this
reason,
> instead of writing the digits 100 or 10 as such in the Chinese translations,
> they have been expressed as 1 + the amount of thousands needed to make either
> 100 million or 10 million in Chinese characters. Therefore we cannot fix 100
and
> 10.  :(  Not sure if this makes sense? :-/

This will make the translations even more complicated, we will need to update
the strings all the time we are making changes on the number, I strongly
recommend if we are going not to have "Fix" on numbers only for Chinese case,
make sense to be sure if writing numbers in Chinese form is non avoidable,
otherwise I'll suggest to keep the general form. Imagine if we will have numbers
that are incremented automatically, we will not be able to do that, even if that
still can be problem with Crowdin, that is something that make sense to consider
for new TMS as well.
@Julian Beside of that we should be able to still use <fix> for numbers I
assume, in case there is only 1 "fix" in the strings, but in  general the way we
are handling translation is incorrect I think, maybe we need to have <fix1>
<fix2> ?
@Tamara so currently you should be able to translate Chinese text if we have
only 1 "fix".

[tamara, 2016-07-11 12:51:15]

On 2016/07/11 08:50:24, saroyanm wrote:
> On 2016/07/08 18:03:42, tamara wrote:
> > On 2016/07/08 17:38:08, juliandoucette wrote:
> > > @tamara can you verify that we are translating our user numbers correctly?
> > > 
> > > We are currently formatting them like so "<fix>100</fix> million active
> > > devices". This implies that "100" will not be translated and "million
active
> > > devices" will always be translated and appear after "100".
> > 
> > I'm afraid we won't be able to use that. :-/  Numbers, in Chinese, are
> expressed
> > differently than in other languages: "Chinese forms numbers between 10,000
and
> > 100,000,000 based off of how many tens of thousands they have." For this
> reason,
> > instead of writing the digits 100 or 10 as such in the Chinese translations,
> > they have been expressed as 1 + the amount of thousands needed to make
either
> > 100 million or 10 million in Chinese characters. Therefore we cannot fix 100
> and
> > 10.  :(  Not sure if this makes sense? :-/
> 
> This will make the translations even more complicated, we will need to update
> the strings all the time we are making changes on the number, I strongly
> recommend if we are going not to have "Fix" on numbers only for Chinese case,
> make sense to be sure if writing numbers in Chinese form is non avoidable,
> otherwise I'll suggest to keep the general form. Imagine if we will have
numbers
> that are incremented automatically, we will not be able to do that, even if
that
> still can be problem with Crowdin, that is something that make sense to
consider
> for new TMS as well.
> @Julian Beside of that we should be able to still use <fix> for numbers I
> assume, in case there is only 1 "fix" in the strings, but in  general the way
we
> are handling translation is incorrect I think, maybe we need to have <fix1>
> <fix2> ?
> @Tamara so currently you should be able to translate Chinese text if we have
> only 1 "fix".

Let me see if I understand this. So you're suggesting to make sure that we
really cannot express Chinese numbers in a more "international" way before
deciding not to go for a "fix" and, therefore, see if it is possible to
translate them only because, if not, this would make translations "even more
complicated"?

[juliandoucette, 2016-07-11 13:00:25]

> This will make the translations even more complicated, we will need to update
> the strings all the time we are making changes on the number, I strongly
> recommend if we are going not to have "Fix" on numbers only for Chinese case,
> make sense to be sure if writing numbers in Chinese form is non avoidable,
> otherwise I'll suggest to keep the general form. Imagine if we will have
numbers
> that are incremented automatically, we will not be able to do that, even if
that
> still can be problem with Crowdin, that is something that make sense to
consider
> for new TMS as well.

I see two separate issues here.

1. How much additional work is it if we do not <fix> numbers?

- @frontend updates the string in the repo
- @crowdin updates all of the translations of that string
- @backend runs the translation script

Am I missing anything? Is this a lot of work for you @tamara? Is this a lot of
work for anyone else?

2. If we cannot <fix> numbers, how do we translate dynamic numbers?

Write a global filter that translates numbers? 

> @Julian Beside of that we should be able to still use <fix> for numbers I
> assume, in case there is only 1 "fix" in the strings, but in  general the way
we
> are handling translation is incorrect I think, maybe we need to have <fix1>
> <fix2> ?

I don't understand what you are asking.

> @Tamara so currently you should be able to translate Chinese text if we have
> only 1 "fix".

I don't understand what you are asking.

[juliandoucette, 2016-07-11 13:04:14]

> 2. If we cannot <fix> numbers, how do we translate dynamic numbers?
> 
> Write a global filter that translates numbers? 

Note: If we do write a global filter to translate chinese numbers then we can
<fix> numbers.

[tamara, 2016-07-11 13:44:51]

On 2016/07/11 13:00:25, juliandoucette wrote:
> > This will make the translations even more complicated, we will need to
update
> > the strings all the time we are making changes on the number, I strongly
> > recommend if we are going not to have "Fix" on numbers only for Chinese
case,
> > make sense to be sure if writing numbers in Chinese form is non avoidable,
> > otherwise I'll suggest to keep the general form. Imagine if we will have
> numbers
> > that are incremented automatically, we will not be able to do that, even if
> that
> > still can be problem with Crowdin, that is something that make sense to
> consider
> > for new TMS as well.
> 
> I see two separate issues here.
> 
> 1. How much additional work is it if we do not <fix> numbers?
> 
> - @frontend updates the string in the repo
> - @crowdin updates all of the translations of that string
> - @backend runs the translation script
> 
> Am I missing anything? Is this a lot of work for you @tamara? Is this a lot of
> work for anyone else?
> 


Definitely not for me, hence my question to Manvel, as I'm afraid we cannot
translate numbers in Chinese to a more "international" way in order to be able
to <fix> all the languages. However, I'm still not sure if that's what he was
asking or not. :-/

[saroyanm, 2016-07-11 14:22:18]

On 2016/07/11 13:44:51, tamara wrote:
> On 2016/07/11 13:00:25, juliandoucette wrote:
> > > This will make the translations even more complicated, we will need to
> update
> > > the strings all the time we are making changes on the number, I strongly
> > > recommend if we are going not to have "Fix" on numbers only for Chinese
> case,
> > > make sense to be sure if writing numbers in Chinese form is non avoidable,
> > > otherwise I'll suggest to keep the general form. Imagine if we will have
> > numbers
> > > that are incremented automatically, we will not be able to do that, even
if
> > that
> > > still can be problem with Crowdin, that is something that make sense to
> > consider
> > > for new TMS as well.
> > 
> > I see two separate issues here.
> > 
> > 1. How much additional work is it if we do not <fix> numbers?
> > 
> > - @frontend updates the string in the repo
> > - @crowdin updates all of the translations of that string
> > - @backend runs the translation script
> > 
> > Am I missing anything? Is this a lot of work for you @tamara? Is this a lot
of
> > work for anyone else?
> > 
> 
> 
> Definitely not for me, hence my question to Manvel, as I'm afraid we cannot
> translate numbers in Chinese to a more "international" way in order to be able
> to <fix> all the languages. However, I'm still not sure if that's what he was
> asking or not. :-/

This mean whenever we will change the numbers the translations will be removed,
so yes this will require to translate it again in Crowdin and run the sync
script, which will make the process more longer, also we should consider that
can affect other logics in future that generating numbers automatically, ex.
team number in eyeo, that is being generated automatically and if we will
translate the website this will become issue. 

I can see another solution for this ticket, @Julian you can keep "fix" tags and
we will translate the Chinese numbers to whatever format they have, this mean
whenever we will change the number, the numbers will be changed for all
languages except of Chinese, which we will update manually, or use "fix" this is
something that Tamara can think about, if it's better to do exception or use
international format(how it was done beforehand).

Sorry guys if my explanations are not understandable, let me know if something
is unclear yet, we can setup a meeting if you want to align about this question,
I hope I could describe my concerns better.

[tamara, 2016-07-11 15:25:45]

On 2016/07/11 14:22:18, saroyanm wrote:
> On 2016/07/11 13:44:51, tamara wrote:
> > On 2016/07/11 13:00:25, juliandoucette wrote:
> > > > This will make the translations even more complicated, we will need to
> > update
> > > > the strings all the time we are making changes on the number, I strongly
> > > > recommend if we are going not to have "Fix" on numbers only for Chinese
> > case,
> > > > make sense to be sure if writing numbers in Chinese form is non
avoidable,
> > > > otherwise I'll suggest to keep the general form. Imagine if we will have
> > > numbers
> > > > that are incremented automatically, we will not be able to do that, even
> if
> > > that
> > > > still can be problem with Crowdin, that is something that make sense to
> > > consider
> > > > for new TMS as well.
> > > 
> > > I see two separate issues here.
> > > 
> > > 1. How much additional work is it if we do not <fix> numbers?
> > > 
> > > - @frontend updates the string in the repo
> > > - @crowdin updates all of the translations of that string
> > > - @backend runs the translation script
> > > 
> > > Am I missing anything? Is this a lot of work for you @tamara? Is this a
lot
> of
> > > work for anyone else?
> > > 
> > 
> > 
> > Definitely not for me, hence my question to Manvel, as I'm afraid we cannot
> > translate numbers in Chinese to a more "international" way in order to be
able
> > to <fix> all the languages. However, I'm still not sure if that's what he
was
> > asking or not. :-/
> 
> This mean whenever we will change the numbers the translations will be
removed,
> so yes this will require to translate it again in Crowdin and run the sync
> script, which will make the process more longer, also we should consider that
> can affect other logics in future that generating numbers automatically, ex.
> team number in eyeo, that is being generated automatically and if we will
> translate the website this will become issue. 
> 
> I can see another solution for this ticket, @Julian you can keep "fix" tags
and
> we will translate the Chinese numbers to whatever format they have, this mean
> whenever we will change the number, the numbers will be changed for all
> languages except of Chinese, which we will update manually, or use "fix" this
is
> something that Tamara can think about, if it's better to do exception or use
> international format(how it was done beforehand).
> 
> Sorry guys if my explanations are not understandable, let me know if something
> is unclear yet, we can setup a meeting if you want to align about this
question,
> I hope I could describe my concerns better.

If it is possible not to use <fix> for Chinese but still use it for the rest of
the languages, then I'd rather go for that.

[saroyanm, 2016-07-11 15:33:48]

On 2016/07/11 15:25:45, tamara wrote:
> On 2016/07/11 14:22:18, saroyanm wrote:
> > On 2016/07/11 13:44:51, tamara wrote:
> > > On 2016/07/11 13:00:25, juliandoucette wrote:
> > > > > This will make the translations even more complicated, we will need to
> > > update
> > > > > the strings all the time we are making changes on the number, I
strongly
> > > > > recommend if we are going not to have "Fix" on numbers only for
Chinese
> > > case,
> > > > > make sense to be sure if writing numbers in Chinese form is non
> avoidable,
> > > > > otherwise I'll suggest to keep the general form. Imagine if we will
have
> > > > numbers
> > > > > that are incremented automatically, we will not be able to do that,
even
> > if
> > > > that
> > > > > still can be problem with Crowdin, that is something that make sense
to
> > > > consider
> > > > > for new TMS as well.
> > > > 
> > > > I see two separate issues here.
> > > > 
> > > > 1. How much additional work is it if we do not <fix> numbers?
> > > > 
> > > > - @frontend updates the string in the repo
> > > > - @crowdin updates all of the translations of that string
> > > > - @backend runs the translation script
> > > > 
> > > > Am I missing anything? Is this a lot of work for you @tamara? Is this a
> lot
> > of
> > > > work for anyone else?
> > > > 
> > > 
> > > 
> > > Definitely not for me, hence my question to Manvel, as I'm afraid we
cannot
> > > translate numbers in Chinese to a more "international" way in order to be
> able
> > > to <fix> all the languages. However, I'm still not sure if that's what he
> was
> > > asking or not. :-/
> > 
> > This mean whenever we will change the numbers the translations will be
> removed,
> > so yes this will require to translate it again in Crowdin and run the sync
> > script, which will make the process more longer, also we should consider
that
> > can affect other logics in future that generating numbers automatically, ex.
> > team number in eyeo, that is being generated automatically and if we will
> > translate the website this will become issue. 
> > 
> > I can see another solution for this ticket, @Julian you can keep "fix" tags
> and
> > we will translate the Chinese numbers to whatever format they have, this
mean
> > whenever we will change the number, the numbers will be changed for all
> > languages except of Chinese, which we will update manually, or use "fix"
this
> is
> > something that Tamara can think about, if it's better to do exception or use
> > international format(how it was done beforehand).
> > 
> > Sorry guys if my explanations are not understandable, let me know if
something
> > is unclear yet, we can setup a meeting if you want to align about this
> question,
> > I hope I could describe my concerns better.
> 
> If it is possible not to use <fix> for Chinese but still use it for the rest
of
> the languages, then I'd rather go for that.

Yes I think it's best what we can do right now.
@Julian if you also agree on that, can you please revert the removal of "FIX"
tags and I'll have a look into review after.

[juliandoucette, 2016-07-12 14:57:53]

> > If it is possible not to use <fix> for Chinese but still use it for the rest
> of
> > the languages, then I'd rather go for that.
> 
> Yes I think it's best what we can do right now.
> @Julian if you also agree on that, can you please revert the removal of "FIX"
> tags and I'll have a look into review after.

Wait a minute...

If we leave the <fix>, don't we have to manually update the string on the
Chinese page every time we update the site and/or translations?

https://media.giphy.com/media/WfyP9ebBuovu0/giphy.gif

[saroyanm, 2016-07-12 15:29:48]

On 2016/07/12 14:57:53, juliandoucette wrote:
> > > If it is possible not to use <fix> for Chinese but still use it for the
rest
> > of
> > > the languages, then I'd rather go for that.
> > 
> > Yes I think it's best what we can do right now.
> > @Julian if you also agree on that, can you please revert the removal of
"FIX"
> > tags and I'll have a look into review after.
> 
> Wait a minute...
> 
> If we leave the <fix>, don't we have to manually update the string on the
> Chinese page every time we update the site and/or translations?
> 
> https://media.giphy.com/media/WfyP9ebBuovu0/giphy.gif

We will need to update the translation in crowdin - we will just not use <fix>
tag in the Chinese translation, I think it's still better than updating that
number on each other language manually.
So translation strings will look like this:
Original -> We have <fix>100</fix> visitors
Russian -> У нас есть <fix> посетителей
Chinese -> 我們有100名遊客

[juliandoucette, 2016-07-12 15:53:05]

> We will need to update the translation in crowdin - we will just not use <fix>
> tag in the Chinese translation, I think it's still better than updating that
> number on each other language manually.
> So translation strings will look like this:
> Original -> We have <fix>100</fix> visitors
> Russian -> У нас есть <fix> посетителей
> Chinese -> 我們有100名遊客

Oh, you mean that the translators can override the <fix>?

[saroyanm, 2016-07-12 16:02:02]

On 2016/07/12 15:53:05, juliandoucette wrote:
> > We will need to update the translation in crowdin - we will just not use
<fix>
> > tag in the Chinese translation, I think it's still better than updating that
> > number on each other language manually.
> > So translation strings will look like this:
> > Original -> We have <fix>100</fix> visitors
> > Russian -> У нас есть <fix> посетителей
> > Chinese -> 我們有100名遊客
> 
> Oh, you mean that the translators can override the <fix>?

Yes, AFAIK, it should be possible, otherwise we will need to be sure that each
separate localized string has <fix> inside of it, which is easy to forget.

[juliandoucette, 2016-07-14 17:05:18]

On 2016/07/12 16:02:02, saroyanm wrote:
> On 2016/07/12 15:53:05, juliandoucette wrote:
> > > We will need to update the translation in crowdin - we will just not use
> <fix>
> > > tag in the Chinese translation, I think it's still better than updating
that
> > > number on each other language manually.
> > > So translation strings will look like this:
> > > Original -> We have <fix>100</fix> visitors
> > > Russian -> У нас есть <fix> посетителей
> > > Chinese -> 我們有100名遊客
> > 
> > Oh, you mean that the translators can override the <fix>?
> 
> Yes, AFAIK, it should be possible, otherwise we will need to be sure that each
> separate localized string has <fix> inside of it, which is easy to forget.

Done.

[saroyanm, 2016-07-25 12:43:29]

As mentioned in the ticket "Note" section we need to update the locale files as
well for the homepage strings.

[juliandoucette, 2016-08-16 16:57:18]

On 2016/07/25 12:43:29, saroyanm wrote:
> As mentioned in the ticket "Note" section we need to update the locale files
as
> well for the homepage strings.

I'm not exactly sure what you mean here. Can you elaborate, do it yourself, or
give an example?

[juliandoucette, 2016-08-16 17:12:05]

Don't forget about the previous question too ^ .

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl...
includes/index.tmpl:33: <meta content="{{"Adblock Plus is the most popular
adblocker available for Firefox, Chrome, Opera, Safari, Android and Internet
Explorer. Block all annoying ads all over the web: remove video ads on YouTube,
block Facebook ads, get rid of pop-ups and much more. On Google Chrome, Adblock
Plus is one of the fastest growing extensions ever. Adblock Plus for Chrome is
used by 10 million people worldwide.. Download online for free
now!"|translate("s2")}}" name="description">
1. I don't remember this being part of this patch :/ 
2. The user number is wrong here isn't it?

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl...
includes/index.tmpl:35: <meta content="{{"Adblock Plus is the most popular
adblocker available for Firefox, Chrome, Opera, Safari, Android and Internet
Explorer. Block all annoying ads all over the web: remove video ads on YouTube,
block Facebook ads, get rid of pop-ups and much more. On Google Chrome, Adblock
Plus is one of the fastest growing extensions ever. Adblock Plus for Chrome is
used by 10 million people worldwide.. Download online for free
now!"|translate("s2")}}" property="og:description">
Same as comment above ^

[saroyanm, 2016-08-18 10:20:54]

On 2016/08/16 16:57:18, juliandoucette wrote:
> On 2016/07/25 12:43:29, saroyanm wrote:
> > As mentioned in the ticket "Note" section we need to update the locale files
> as
> > well for the homepage strings.
> 
> I'm not exactly sure what you mean here. Can you elaborate, do it yourself, or
> give an example?

Just scratch that, I'm trying to find a solution, to be able also somehow update
the homepage strings using crowdin, otherwise I'll provide you patch with all
updated strings manually.

[saroyanm, 2016-08-18 10:21:09]

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl...
includes/index.tmpl:33: <meta content="{{"Adblock Plus is the most popular
adblocker available for Firefox, Chrome, Opera, Safari, Android and Internet
Explorer. Block all annoying ads all over the web: remove video ads on YouTube,
block Facebook ads, get rid of pop-ups and much more. On Google Chrome, Adblock
Plus is one of the fastest growing extensions ever. Adblock Plus for Chrome is
used by 10 million people worldwide.. Download online for free
now!"|translate("s2")}}" name="description">
On 2016/08/16 17:12:04, juliandoucette wrote:
> 1. I don't remember this being part of this patch :/
It's in the ticket, so I guess this also should be in the patch
> 2. The user number is wrong here isn't it?
Addressed in the ticket.

[saroyanm, 2016-08-22 10:09:00]

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29347420/diff/29347421/includes/index.tmpl...
includes/index.tmpl:33: <meta content="{{"Adblock Plus is the most popular
adblocker available for Firefox, Chrome, Opera, Safari, Android and Internet
Explorer. Block all annoying ads all over the web: remove video ads on YouTube,
block Facebook ads, get rid of pop-ups and much more. On Google Chrome, Adblock
Plus is one of the fastest growing extensions ever. Adblock Plus for Chrome is
used by 10 million people worldwide.. Download online for free
now!"|translate("s2")}}" name="description">
On 2016/08/18 10:21:08, saroyanm wrote:
> On 2016/08/16 17:12:04, juliandoucette wrote:
> > 1. I don't remember this being part of this patch :/
> It's in the ticket, so I guess this also should be in the patch
> > 2. The user number is wrong here isn't it?
> Addressed in the ticket.
> 

The text should, be changed to: Adblock Plus is used on over 100 million devices
please
Please also update it consistently for the meta tag below.

[juliandoucette, 2016-09-26 20:19:05]

> The text should, be changed to: Adblock Plus is used on over 100 million
devices
> please
> Please also update it consistently for the meta tag below.

Done. We should probably prioritize this change now.

[saroyanm, 2016-10-05 17:54:02]

Sorry that it took so long,

LGTM with just one small comment.

https://codereview.adblockplus.org/29347420/diff/29355099/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29347420/diff/29355099/includes/index.tmpl...
includes/index.tmpl:238: {{"The add-on is developed by the open source community
and free to use for everybody. With more than <fix>100</fix> active devices,
<fix>Adblock Plus</fix> is one of the most popular browser extensions for
<fix>Google Chrome</fix>."|translate("s67")}}
"100 million active devices"

[juliandoucette, 2016-10-06 13:17:10]

Thanks Manvel!

Do we have to wait for translations before we push this?

https://codereview.adblockplus.org/29347420/diff/29355099/includes/index.tmpl
File includes/index.tmpl (right):

https://codereview.adblockplus.org/29347420/diff/29355099/includes/index.tmpl...
includes/index.tmpl:238: {{"The add-on is developed by the open source community
and free to use for everybody. With more than <fix>100</fix> active devices,
<fix>Adblock Plus</fix> is one of the most popular browser extensions for
<fix>Google Chrome</fix>."|translate("s67")}}
On 2016/10/05 17:54:02, saroyanm wrote:
> "100 million active devices"

Good catch! :D

[saroyanm, 2016-10-06 13:42:40]

On 2016/10/06 13:17:10, juliandoucette wrote:
> Thanks Manvel!
> 
> Do we have to wait for translations before we push this?
Just aligned with @Tamara:
We do have translations except of 1 string, she will try to translate that
string until tomorrow, if not we will push early week

[tamara, 2016-10-06 14:35:42]

On 2016/10/06 13:42:40, saroyanm wrote:
> On 2016/10/06 13:17:10, juliandoucette wrote:
> > Thanks Manvel!
> > 
> > Do we have to wait for translations before we push this?
> Just aligned with @Tamara:
> We do have translations except of 1 string, she will try to translate that
> string until tomorrow, if not we will push early week

Sorted! The string has been updated to the corresponding translations. All of
them should be final now. :D

[saroyanm, 2016-10-07 09:35:03]

On 2016/10/06 14:35:42, tamara wrote:
> On 2016/10/06 13:42:40, saroyanm wrote:
> > On 2016/10/06 13:17:10, juliandoucette wrote:
> > > Thanks Manvel!
> > > 
> > > Do we have to wait for translations before we push this?
> > Just aligned with @Tamara:
> > We do have translations except of 1 string, she will try to translate that
> > string until tomorrow, if not we will push early week
> 
> Sorted! The string has been updated to the corresponding translations. All of
> them should be final now. :D

I'll suggest to push the changes early next week, anyway while it's end of the
week and would be great to have us 3 available in case smth needs to be changed,
or goes wrong, just in case.

[juliandoucette, 2016-10-07 15:36:58]

> I'll suggest to push the changes early next week, anyway while it's end of the
> week and would be great to have us 3 available in case smth needs to be
changed,
> or goes wrong, just in case.

Sounds good.

[juliandoucette, 2016-10-11 12:13:28]

Pushed. 

https://hg.adblockplus.org/web.adblockplus.org/rev/64f96862ec13