Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 29347785: Issue 4243 - NS_ERROR_ILLEGAL_VALUE exception in utils.getFrames() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by Wladimir Palant
Modified:
3 years, 4 months ago
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Issue 4243 - NS_ERROR_ILLEGAL_VALUE exception in utils.getFrames() Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M lib/child/elemHide.js View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 4 months ago (2016-07-14 13:44:20 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29347785/diff/29347786/lib/child/elemHide.js File lib/child/elemHide.js (right): https://codereview.adblockplus.org/29347785/diff/29347786/lib/child/elemHide.js#newcode330 lib/child/elemHide.js:330: // The window is in an invalid state - ...
3 years, 4 months ago (2016-07-14 14:19:21 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29347785/diff/29347786/lib/child/elemHide.js File lib/child/elemHide.js (right): https://codereview.adblockplus.org/29347785/diff/29347786/lib/child/elemHide.js#newcode330 lib/child/elemHide.js:330: // The window is in an invalid state - ...
3 years, 4 months ago (2016-07-14 15:19:42 UTC) #3
Thomas Greiner
3 years, 4 months ago (2016-07-14 15:43:10 UTC) #4
LGTM

Thanks for the clarification.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5