Issue 4248 - Add codestyle check

build.gradle

Index: build.gradle
diff --git a/build.gradle b/build.gradle
index 6ab4fb584ec17006bd37e78456c3b4e8569ae51a..128ac1b58b43797166ce205f82d805dcf3b3e012 100644
--- a/build.gradle
+++ b/build.gradle
@@ -12,3 +12,10 @@ buildscript {
 subprojects {
   task listAllDependencies(type: DependencyReportTask) {}
 }
+
+configure(subprojects) { subproject ->
+  repositories {
+    mavenCentral()
+    mavenLocal()
+  }
+}

[anton, 2017/04/14 12:02:28]

my original intention was to describe `checkstyle` params here to have single
description. But this behaviour depends on gradle version and i did not found a
way to have the same description for all the version. So just copy-pasted it to
projects `build.gradle`. BTW i did not add checkstyle for `tests` module, should
i?

[diegocarloslima, 2017/04/27 12:58:44]

Can't you define the checkstyle version here (or in settings.gradle) by
declaring "project.ext.checkstyleToolVersion=6.19" and having it used by each
project by reading rootProject.checkstyleToolVersion? If that doesn't works
because of different Gradle versions, have you also considered using a
.properties file where you would declare the checkstyle version?

Yeah, I think it'll be good to check style for the tests module as well

[anton, 2017/04/28 06:05:06]

tool version is just a bit. The main purpose is task arguments - paths, files,
etc.

what about rules for tests - how do you think should we have separate rules
files for it? as it's obviously that some rules are not respected. eg. "Magic
numbers" (delayes, expected values, etc)

[diegocarloslima, 2017/04/28 11:27:37]

Yes, It makes sense to have some special rules for testing