Issue 4211 - Improve detection of uninitialized documents for means of element hiding

lib/child/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 307 matching lines @@
     {
       this.sheet = null;
     });
   },
 
   observe: function(subject, topic, data)
   {
     if (topic != this.topic)
       return;
 
-    if (!subject.location || !subject.location.href)
+    if (subject.document.readyState == "uninitialized")
     {
-      // The window is in an invalid state - delay processing until it's ready.
+      // It would be nice to listen to the readystatechange event here. However,
+      // it doesn't fire when changing from "uninitialized" state.

[Thomas Greiner, 2016/07/18 15:58:14]

While the "unitialized" state is not mentioned in
https://www.w3.org/TR/html5/dom.html#documentreadystate (the listed states are
considered non-normative so no issue), it clearly states that "When the value is
set, the user agent must fire a simple event named readystatechange at the
Document object." (see
https://www.w3.org/TR/html5/dom.html#current-document-readiness) so seems to be
a browser issue.

[Wladimir Palant, 2016/07/18 18:07:18]

Given that "uninitialized" means "too early to be seen by any content JavaScript
code" - it's not surprising that Gecko devs cut this corner and don't fire an
event for the state change here. You can only observe this state from an
extension, and even here it might be considered a bug. Arguably,
content-document-global-created notification shouldn't fire before the document
is initialized.

       Utils.runAsync(() =>
       {
         if (!Cu.isDeadWrapper(subject))
-          this.observe(subject, topic, data)
+          this.observe(subject, topic, data);
       });
       return;
     }
 
     port.emitWithResponse("elemhideEnabled", {
       frames: getFrames(subject),
       isPrivate: isPrivate(subject)
     }).then(({
       enabled, contentType, docDomain, thirdParty, location, filter,
       filterType
@@ skipping 31 matching lines @@
       else if (filter)
       {
         RequestNotifier.addNodeData(subject.document, subject.top, {
           contentType, docDomain, thirdParty, location, filter, filterType
         });
       }
     });
   }
 };
 observer.init();