messageResponder.js - Issue 29347939: Issue 4201 - CSS property filter still applied when ABP is disabled everywhere

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: messageResponder.js

Issue 29347939: Issue 4201 - CSS property filter still applied when ABP is disabled everywhere (Closed)

Patch Set: Created July 18, 2016, 3:53 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: messageResponder.js

===================================================================

--- a/messageResponder.js

+++ b/messageResponder.js

@@ -220,17 +220,17 @@

callback(filter instanceof BlockingFilter);

break;

case "filters.get":

if (message.what == "cssproperties")

{

var filters = [];

var checkWhitelisted = require("whitelisting").checkWhitelisted;

- if (!checkWhitelisted(sender.page, sender.frame,

+ if (Prefs.enabled && !checkWhitelisted(sender.page, sender.frame,

RegExpFilter.typeMap.DOCUMENT |

RegExpFilter.typeMap.ELEMHIDE))

{

filters = CSSRules.getRulesForDomain(sender.frame.url.hostname);

filters = filters.map(function(filter)

{

return {

prefix: filter.selectorPrefix,

« no previous file with comments | « no previous file | no next file » | no next file with comments »