README.md - Issue 29348393: Issue 4259 - Change libadblockplus-android description in README

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: README.md

Issue 29348393: Issue 4259 - Change libadblockplus-android description in README (Closed)

Patch Set: Created July 22, 2016, 12:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Adblock Plus Library for Android	1 Adblock Plus Library for Android

2 ========================	2 ========================

3	3

4 An Android library project that runs a proxy to block ads.	4 An Android library project that provides an opportunity to use adblockplus core

	5 functionality in Java/Android.
	diegocarloslima 2016/09/08 15:33:51 The choice of the best description is a bit subjec The choice of the best description is a bit subjective, but I would suggest changing to 'An Android library project that makes easier to use Adblock Plus core functionality in Java/Android.' anton 2016/09/09 06:48:18 Easier means that there is another way (probably m Show quoted text On 2016/09/08 15:33:51, diegocarloslima wrote: > The choice of the best description is a bit subjective, but I would suggest > changing to 'An Android library project that makes easier to use Adblock Plus > core functionality in Java/Android.' Easier means that there is another way (probably more difficult or just another). One could create C++ android app and abp C++ classes directly without these "JNI-glue" classes but i'd say it's for hardcore developers who love pain. One could create completely JS app and JS abp code but it's also very rare use case. So i'd say using this library is only way to use abp core functionality. diegocarloslima 2016/11/03 10:48:45 OK, got your point there, so I would just suggest Show quoted text On 2016/09/09 06:48:18, anton wrote: > On 2016/09/08 15:33:51, diegocarloslima wrote: > > The choice of the best description is a bit subjective, but I would suggest > > changing to 'An Android library project that makes easier to use Adblock Plus > > core functionality in Java/Android.' > > Easier means that there is another way (probably more difficult or just > another). One could create C++ android app and abp C++ classes directly without > these "JNI-glue" classes but i'd say it's for hardcore developers who love pain. > One could create completely JS app and JS abp code but it's also very rare use > case. > > So i'd say using this library is only way to use abp core functionality. OK, got your point there, so I would just suggest to change 'use adblockplus core...' to 'use Adblock Plus core...' anton 2016/12/02 06:10:03 Acknowledged. Show quoted text On 2016/11/03 10:48:45, diegocarloslima wrote: > On 2016/09/09 06:48:18, anton wrote: > > On 2016/09/08 15:33:51, diegocarloslima wrote: > > > The choice of the best description is a bit subjective, but I would suggest > > > changing to 'An Android library project that makes easier to use Adblock > Plus > > > core functionality in Java/Android.' > > > > Easier means that there is another way (probably more difficult or just > > another). One could create C++ android app and abp C++ classes directly > without > > these "JNI-glue" classes but i'd say it's for hardcore developers who love > pain. > > One could create completely JS app and JS abp code but it's also very rare use > > case. > > > > So i'd say using this library is only way to use abp core functionality. > > OK, got your point there, so I would just suggest to change 'use adblockplus > core...' to 'use Adblock Plus core...' Acknowledged.
5	6

6 Updating the dependencies	7 Updating the dependencies

7 -------------------------	8 -------------------------

8	9

9 Adblock Plus Library for Android has dependencies that aren't in this repository .	10 Adblock Plus Library for Android has dependencies that aren't in this repository .

10 To update those, call:	11 To update those, call:

11	12

12 ./ensure_dependencies.py	13 ./ensure_dependencies.py

13	14

14 ## Library	15 ## Library

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
87	88

88 ant testOnly -DtestClass=org.adblockplus.libadblockplus.tests.NotificationTe st	89 ant testOnly -DtestClass=org.adblockplus.libadblockplus.tests.NotificationTe st

89	90

90 To run specific test method run:	91 To run specific test method run:

91	92

92 ant testOnly -DtestClass=full.test.class.name#testMethod	93 ant testOnly -DtestClass=full.test.class.name#testMethod

93	94

94 For example:	95 For example:

95	96

96 ant testOnly -DtestClass=org.adblockplus.libadblockplus.tests.NotificationTe st#testAddNotification	97 ant testOnly -DtestClass=org.adblockplus.libadblockplus.tests.NotificationTe st#testAddNotification

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »