Delta Between Two Patch Sets: new-options.html
Issue 29348642:
Issue 2409 - Improved accessibility of tabs in options page (Closed)
Left Patch Set:
Created July 25, 2016, 3:01 p.m.
Right Patch Set:
Created July 26, 2016, 12:48 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
new-options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2016 Eyeo GmbH | 4 - Copyright (C) 2006-2016 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 52 aria-controls="content-advanced" tabindex="-1"> | 52 aria-controls="content-advanced" tabindex="-1"> |
| 53 <span class="i18n_options_tab_advanced"></span> | 53 <span class="i18n_options_tab_advanced"></span> |
| 54 </li> | 54 </li> |
| 55 <li id="tab-help" role="tab" data-tab="help" | 55 <li id="tab-help" role="tab" data-tab="help" |
| 56 aria-controls="content-help" tabindex="-1"> | 56 aria-controls="content-help" tabindex="-1"> |
| 57 <span class="i18n_options_tab_help"></span> | 57 <span class="i18n_options_tab_help"></span> |
| 58 </li> | 58 </li> |
| 59 </ul> | 59 </ul> |
| 60 </nav> | 60 </nav> |
| 61 | 61 |
| 62 <a id="link-version" tabindex="0"> | 62 <a id="link-version"> |
|
Thomas Greiner
2016/07/26 12:50:49
Turns out to not be necessary since we're setting
| |
| 63 <span class="i18n_options_version"></span> | 63 <span class="i18n_options_version"></span> |
| 64 <span id="abp-version"></span> | 64 <span id="abp-version"></span> |
| 65 </a> | 65 </a> |
| 66 | 66 |
| 67 <footer> | 67 <footer> |
| 68 <ul class="tabs vertical bottom" data-action="open-doclink" | 68 <ul class="tabs vertical bottom" data-action="open-doclink" |
| 69 data-keys="Enter"> | 69 data-keys="Enter"> |
| 70 <li id="tab-share" data-doclink="share-general" tabindex="0"> | 70 <li id="tab-share" data-doclink="share-general" tabindex="0"> |
| 71 <span class="i18n_options_tab_share"></span> | 71 <span class="i18n_options_tab_share"></span> |
| 72 </li> | 72 </li> |
| (...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 418 <div class="url"></div> | 418 <div class="url"></div> |
| 419 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 419 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 420 </div> | 420 </div> |
| 421 </div> | 421 </div> |
| 422 </div> | 422 </div> |
| 423 <!-- Placeholder element to determine when to wrap focus around --> | 423 <!-- Placeholder element to determine when to wrap focus around --> |
| 424 <span class="focus-last" tabindex="0"></span> | 424 <span class="focus-last" tabindex="0"></span> |
| 425 </div> | 425 </div> |
| 426 </body> | 426 </body> |
| 427 </html> | 427 </html> |
| LEFT | RIGHT |
« no previous file
|
new-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
