Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: mozharness/abb/transform_locales.py

Issue 29348650: Issue 3199 - "Firefox" string is displayed on several error messages (Closed)
Left Patch Set: Some readability improvements according to Felix's suggestions Created Dec. 27, 2016, 9:40 p.m.
Right Patch Set: Fixing typo Created Jan. 2, 2017, 4:32 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of Adblock Plus 1 # This file is part of Adblock Plus
2 # Copyright (C) 2006-2015 Eyeo GmbH 2 # Copyright (C) 2006-2015 Eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 "yahoo", 52 "yahoo",
53 "google", 53 "google",
54 "wikipedia", 54 "wikipedia",
55 "amazon" 55 "amazon"
56 ] 56 ]
57 } 57 }
58 58
59 _FIREFOX_REPLACE_STR = "Firefox" 59 _FIREFOX_REPLACE_STR = "Firefox"
60 _ABB_REPLACEMENT_STR = "Adblock Browser" 60 _ABB_REPLACEMENT_STR = "Adblock Browser"
61 61
62 # Some string values that contains Firefox such as 'Firefox Sync' shouldn't be 62 # Some string values that contain Firefox such as 'Firefox Sync' shouldn't be
Felix Dahlke 2017/01/02 14:27:16 Nit: s/contains/contain/
63 # replaced, so we keep a list of ids that are exceptions 63 # replaced, so we keep a list of ids that are exceptions
64 _ENTITY_EXCEPTIONS = [ 64 _ENTITY_EXCEPTIONS = [
65 "overlay_no_synced_devices", 65 "overlay_no_synced_devices",
66 "home_remote_tabs_need_to_sign_in", 66 "home_remote_tabs_need_to_sign_in",
67 "home_remote_tabs_need_to_finish_migrating", 67 "home_remote_tabs_need_to_finish_migrating",
68 "home_remote_tabs_need_to_verify", 68 "home_remote_tabs_need_to_verify",
69 "syncBrand.fullName.label", 69 "syncBrand.fullName.label",
70 "sync.subtitle.connectlocation2.label", 70 "sync.subtitle.connectlocation2.label",
71 "sync.subtitle.failmultiple.label", 71 "sync.subtitle.failmultiple.label",
72 "fxaccount_full_label", 72 "fxaccount_full_label",
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
302 locale_path = os.path.join(chrome_path, locale, "locale", locale) 302 locale_path = os.path.join(chrome_path, locale, "locale", locale)
303 if os.path.exists(locale_path): 303 if os.path.exists(locale_path):
304 _transform_locale(locale, locale_path, logger) 304 _transform_locale(locale, locale_path, logger)
305 else: 305 else:
306 logger.error("Missing folder for locale '%s' in path: %s" % 306 logger.error("Missing folder for locale '%s' in path: %s" %
307 (locale, locale_path)) 307 (locale, locale_path))
308 308
309 for locale in values_locales: 309 for locale in values_locales:
310 locale_path = os.path.join(res_path, "values-" + locale) 310 locale_path = os.path.join(res_path, "values-" + locale)
311 _transform_values_locale(locale, locale_path, logger) 311 _transform_values_locale(locale, locale_path, logger)
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld