NoIssue - Use localStorage for storing filters in current Windows Store version of ABP for Edge

lib/adblockplus.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 342 matching lines @@
   var keyPrefix = "file:";
 
   function fileToKey(file)
   {
     return keyPrefix + (file instanceof FakeFile ? file.path : file.spec);
   }
 
   function loadFile(file, successCallback, errorCallback)
   {
     var key = fileToKey(file);
-    ext.storage.get([key], function(items)
-    {
-      var entry = items[key];
-      if (entry)
-      {
-        successCallback(entry);
-      }
-      else
-      {
-        errorCallback(new Error("File doesn't exist"));
-      }
-    });
+    entry = localStorage.getItem(key);

[kzar, 2016/07/27 10:08:14]

You missed the `var`.

+    if (entry)
+      successCallback(JSON.parse(entry));
+    else
+      errorCallback(new Error("File doesn't exist"));
   }
 
   function saveFile(file, data, callback)
   {
-    ext.storage.set(fileToKey(file),
+    try
     {
-      content: data,
-      lastModified: Date.now()
-    }, callback);
+      localStorage.setItem(fileToKey(file), JSON.stringify({
+        content: data,
+        lastModified: Date.now()
+      }));
+    }
+    catch(error)
+    {
+      // QuotaExceededError can happen. Notify the user and ignore
+      alert("Subscription storage is full. Please remove some subscriptions and try again.");

[kzar, 2016/07/27 10:08:15]

Nit: These lines are too long.

+      callback(new Error("Subscription storage is full. Please remove some subscriptions and try again."));

[kzar, 2016/07/27 10:08:14]

Mind putting the message in a variable instead of duplicating it?

Also what about localisation? (I'm not sure if that's out of scope for now or
not.)

[shoniko, 2016/07/27 10:46:51]

If we are going to push this we should do it ASAP. Unfortunately I don't think
there's time to a translation round anymore.

+      return;
+    }
+    callback();
   }
   exports.IO = {
     resolveFilePath: function(path)
     {
       return new FakeFile(path);
     },
     readFromFile: function(file, listener, callback)
     {
       function onLoaded(entry)
       {
@@ skipping 6143 matching lines @@
     search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));
     chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" + search.join("&"));
   }
   if ("setUninstallURL" in chrome.runtime)
   {
     Prefs.untilLoaded.then(setUninstallURL);
     Prefs.on("notificationdata", setUninstallURL);
   }
   return exports;
 })();