NoIssue - Use localStorage for storing filters in current Windows Store version of ABP for Edge

lib/adblockplus.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 342 matching lines @@
   var keyPrefix = "file:";
 
   function fileToKey(file)
   {
     return keyPrefix + (file instanceof FakeFile ? file.path : file.spec);
   }
 
   function loadFile(file, successCallback, errorCallback)
   {
     var key = fileToKey(file);
-    dataInJson = localStorage.getItem(key);
-    if (dataInJson != null)

[kzar, 2016/07/27 08:44:21]

Perhaps just check if dataInJson is truthy like the previous code did? (The `!=
null` comparison makes me nervous since the data could apparently be either null
or a string at this point.)

Nit: I liked the name entry better than dataInJson.

-      successCallback(JSON.parse(dataInJson));
+    var entry = localStorage.getItem(key);
+    if (entry)
+    {
+      successCallback(JSON.parse(entry));
+    }
     else
-      errorCallback(new Error("File doesn't exist"));
-  }
-
+    {
+      // Also check the chrome.storage.local
+      // We may have a init data there
+      ext.storage.get([key], function(items)
+      {
+        var entry = items[key];
+        if (entry)
+          successCallback(entry);
+        else
+          errorCallback(new Error("File doesn't exist"));
+      });
+    }
+  }
   function saveFile(file, data, callback)
   {
     try
     {
       localStorage.setItem(fileToKey(file), JSON.stringify({

[kzar, 2016/07/27 08:44:21]

Nit: The indentation here looks kind of weird. How about this?

localStorage.setItem(fileToKey(file), JSON.stringify({
  content: data,
  lastModified: Date.now()
}));

-                                                content: data,
-                                                lastModified: Date.now()
-                                            }
-                          ));
+        content: data,
+        lastModified: Date.now()
+      }));
     }
     catch(error)
     {
-      // QuotaExceededError can happen. Ignore silently

[kzar, 2016/07/27 08:44:21]

Maybe we should display an alert that asks the user to remove some
subscriptions?

+      // QuotaExceededError can happen. Notify the user and ignore
+      var errorMessage = "Subscription storage is full. " + 
+        "Please remove some subscriptions and try again.";
+      alert(errorMessage);
+      callback(new Error(errorMessage));
+      return;
     }
     callback();
   }
   exports.IO = {
     resolveFilePath: function(path)
     {
       return new FakeFile(path);
     },
     readFromFile: function(file, listener, callback)
     {
@@ skipping 6145 matching lines @@
     search.push("notificationDownloadCount=" + encodeURIComponent(downlCount));
     chrome.runtime.setUninstallURL(Utils.getDocLink("uninstalled") + "&" + search.join("&"));
   }
   if ("setUninstallURL" in chrome.runtime)
   {
     Prefs.untilLoaded.then(setUninstallURL);
     Prefs.on("notificationdata", setUninstallURL);
   }
   return exports;
 })();