issue 4087 - Use Mozilla's product-details data to determine current product versions

globals/get_browser_versions.py

 import re
 import os
 import sys
 import json
 import urllib
 import errno
 import logging
 import time
 from xml.dom import minidom
 
 from jinja2 import contextfunction
 
 BROWSERS = {}
+BASE_URL = 'https://product-details.mozilla.org/1.0'
+FIREFOX_URL = BASE_URL + '/firefox_versions.json'
+THUNDERBIRD_URL = BASE_URL + '/thunderbird_versions.json'
+SEAMONKEY_URL = 'http://www.seamonkey-project.org/seamonkey_versions.json'
 
 CHROME_UPDATE_XML = '''\
 <?xml version="1.0" encoding="UTF-8"?>
 <request protocol="3.0" ismachine="0">
   <os platform="win" version="99" arch="x64"/>
   <app appid="{4DC8B4CA-1BDA-483E-B5FA-D3C12E15B62D}">
     <updatecheck/>
   </app>
   <app appid="{4DC8B4CA-1BDA-483E-B5FA-D3C12E15B62D}" ap="x64-beta-multi-chrome">
     <updatecheck/>
   </app>
   <app appid="{4DC8B4CA-1BDA-483E-B5FA-D3C12E15B62D}" ap="x64-dev-multi-chrome">
     <updatecheck/>
   </app>
 </request>'''
 
 cache = {}
 
 
-def get_firefox_version():
-    url = 'https://product-details.mozilla.org/firefox_versions.json'
-    response = urllib.urlopen(url)
-    try:
-        doc = json.loads(response.read())

[Sebastian Noack, 2016/08/01 16:21:07]

Any reason you cannot parse the response lazily?

  doc = json.load(response)

-    finally:
-        response.close()
+def get_json_versions(product_url):
+    response = urllib.urlopen(product_url)
+    try:
+        doc = json.load(response)
+    except json.ValueError:
+        print 'URL: %s not returning json object'.format(product_url)
+    finally:
+        response.close()
+
+    for key, value in doc.iteritems():
+        if value:
+            match = re.search(r'^(\d+)(?:\.\d+)?', value)
+            if match:
+                doc[key] = match.group(0)
     return doc
 
 
 def get_firefox_versions():
-    versions = get_firefox_version()
+    versions = get_json_versions(FIREFOX_URL)
     return {
             'current': versions['LATEST_FIREFOX_VERSION'],
             'unreleased': [
                 versions['LATEST_FIREFOX_DEVEL_VERSION'],
                 versions['FIREFOX_AURORA'],
                 versions['FIREFOX_NIGHTLY'],
             ]
     }
 
 
-def get_thunderbird_version():
-    url = 'https://product-details.mozilla.org/thunderbird_versions.json'
-    response = urllib.urlopen(url)
-    try:
-        doc = json.loads(response.read())
-    finally:
-        response.close()
-    return doc
-
-
 def get_thunderbird_versions():
-    versions = get_thunderbird_version()
-    firefox_versions = get_firefox_version()
-    return {
-        'current': versions['LATEST_THUNDERBIRD_VERSION'],
+    tbird_versions = get_json_versions(THUNDERBIRD_URL)
+    firefox_versions = get_json_versions(FIREFOX_URL)
+    return {
+        'current': tbird_versions['LATEST_THUNDERBIRD_VERSION'],
         'unreleased': [
-            versions['LATEST_THUNDERBIRD_DEVEL_VERSION'],
-            firefox_versions['FIREFOX_AURORA'],
+            tbird_versions['LATEST_THUNDERBIRD_DEVEL_VERSION'],
+            tbird_versions['LATEST_THUNDERBIRD_ALPHA_VERSION'],
             firefox_versions['FIREFOX_NIGHTLY'],
         ]
     }
 
 BROWSERS['firefox'] = lambda: get_firefox_versions()
 BROWSERS['thunderbird'] = lambda: get_thunderbird_versions()
 
 
-def get_seamonkey_version():

[Sebastian Noack, 2016/08/01 16:21:07]

This code duplication isn't great. How about, instead having one function that
takes the product name (as given in the filename) as argument?

-    url = 'http://www.seamonkey-project.org/seamonkey_versions.json'
-    response = urllib.urlopen(url)
-    try:
-        doc = json.loads(response.read())
-    finally:
-        response.close()
-    return doc
-
-
 def get_seamonkey_versions():
-    # Aurora and Nightly builds for Windows are permantently broken.
-    # Occasionally, builds for other platforms are broken as well.
-    # https://bugzilla.mozilla.org/show_bug.cgi?id=1086553
-    seamonkey_versions = get_seamonkey_version()
+    seamonkey_versions = get_json_versions(SEAMONKEY_URL)
     versions = {
         'current': seamonkey_versions['LATEST_SEAMONKEY_VERSION'],
         'unreleased': [
-            seamonkey_versions['LATEST_SEAMONKEY_DEVEL_VERSION'],
             seamonkey_versions['LATEST_SEAMONKEY_MILESTONE_VERSION'],
             seamonkey_versions['LATEST_SEAMONKEY_TESTING_VERSION'],
+            seamonkey_versions['LATEST_SEAMONKEY_DEVEL_VERSION'],
         ]
     }
 
     return versions
 
 BROWSERS['seamonkey'] = get_seamonkey_versions
 
 
 def get_chrome_version(manifest):
     return manifest.getAttribute('version').split('.')[0]
@@ skipping 143 matching lines @@
         file.seek(0)
         json.dump(persistent_cache, file)
         file.truncate()
 
     if not versions['previous']:
         logging.warning("Couldn't determine previous browser version, "
                         'please set %s.previous in %s', browser, filename)
 
     cache[browser] = versions
     return versions