issue 4087 - Use Mozilla's product-details data to determine current product versions

globals/get_browser_versions.py

 import re
 import os
 import sys
 import json
 import urllib
 import errno
 import logging
 import time
 from xml.dom import minidom
 
 from jinja2 import contextfunction
 
 BROWSERS = {}
-FIREFOX_URL = 'https://product-details.mozilla.org/1.0/firefox_versions.json',

[Vasily Kuznetsov, 2016/08/29 17:27:52]

The comma in the end is not only redundant, it actually breaks the code. 

Please check if the code works before submitting it for review -- the reviewers
might not always do it and unfortunately we have no CI (yet!) to catch these
things.

-THUNDERBIRD_URL = 'https://product-details.mozilla.org/1.0/thunderbird_versions.json',

[Vasily Kuznetsov, 2016/08/29 17:27:52]

This line is too long according to our guidelines (same as PEP8, max 79 chars).

The fix would be to do something like:

THUNDERBIRD_URL = ('......'
                   '.......')

Since this is pretty ugly, you might choose to hack your way out by doing
something like this:

MOZILLA_BASE = 'https://product-details.mozilla.org/1.0/'
FIREFOX_URL = MOZILLA_BASE + 'firefox_versions.json'
THUNDERBIRD_URL = MOZILLA_BASE + 'thunderbird_versions.json'

+BASE_URL = 'https://product-details.mozilla.org/1.0'
+FIREFOX_URL = BASE_URL + '/firefox_versions.json'
+THUNDERBIRD_URL = BASE_URL + '/thunderbird_versions.json'
 SEAMONKEY_URL = 'http://www.seamonkey-project.org/seamonkey_versions.json'
 
 CHROME_UPDATE_XML = '''\
 <?xml version="1.0" encoding="UTF-8"?>
 <request protocol="3.0" ismachine="0">
   <os platform="win" version="99" arch="x64"/>
   <app appid="{4DC8B4CA-1BDA-483E-B5FA-D3C12E15B62D}">
     <updatecheck/>
   </app>
   <app appid="{4DC8B4CA-1BDA-483E-B5FA-D3C12E15B62D}" ap="x64-beta-multi-chrome">
@@ skipping 216 matching lines @@
         file.seek(0)
         json.dump(persistent_cache, file)
         file.truncate()
 
     if not versions['previous']:
         logging.warning("Couldn't determine previous browser version, "
                         'please set %s.previous in %s', browser, filename)
 
     cache[browser] = versions
     return versions