Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29348869: Issue 4101 - Prevent runaway MutationObservers (Closed)

Created:
July 29, 2016, 9:06 a.m. by kzar
Modified:
Aug. 11, 2016, 2:08 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4101 - Prevent runaway MutationObservers

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased. #

Patch Set 3 : Removed _collapsed logic, addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M include.preload.js View 1 2 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
July 29, 2016, 9:08 a.m. (2016-07-29 09:08:35 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29348869/diff/29348870/include.preload.js File include.preload.js (left): https://codereview.adblockplus.org/29348869/diff/29348870/include.preload.js#oldcode159 include.preload.js:159: if (collapse && !element._collapsed) With your changes to collapseElement(), ...
Aug. 10, 2016, 12:55 p.m. (2016-08-10 12:55:57 UTC) #2
kzar
Patch Set 2 : Rebased. Patch Set 3 : Removed _collapsed logic, addressed nits https://codereview.adblockplus.org/29348869/diff/29348870/include.preload.js ...
Aug. 11, 2016, 1:53 p.m. (2016-08-11 13:53:30 UTC) #3
Sebastian Noack
Aug. 11, 2016, 2:06 p.m. (2016-08-11 14:06:52 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld