Issue 4101 - Prevent runaway MutationObservers

include.preload.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 132 matching lines @@
       type: "filters.collapse",
       urls: urls,
       mediatype: mediatype,
       baseURL: document.location.href
     },
 
     function(collapse)
     {
       function collapseElement()
       {
+        var propertyName = "display";
+        var propertyValue = "none";
         if (element.localName == "frame")
-          element.style.setProperty("visibility", "hidden", "important");
-        else
-          element.style.setProperty("display", "none", "important");
+        {
+          propertyName = "visibility";
+          propertyValue = "hidden";
+        }
+
+        if (element.style.getPropertyValue(propertyName) !== propertyValue ||

[Sebastian Noack, 2016/08/10 12:55:57]

Nit: AS per Mozilla's coding practices we perfer != over !==.

[kzar, 2016/08/11 13:53:30]

Done.

+            element.style.getPropertyPriority(propertyName) !== "important")
+          element.style.setProperty(propertyName, propertyValue, "important");
       }
 
       if (collapse && !element._collapsed)

[Sebastian Noack, 2016/08/10 12:55:57]

With your changes to collapseElement(), the _collapsed guard logic became
redundant. For reference, it protects against a similar recursion, where <input
type="image"> elements load thei image again when the styles got changed,
causing it to be blocked again, triggering element collapsing again, and so on.

[kzar, 2016/08/11 13:53:30]

Done.

       {
         collapseElement();
         element._collapsed = true;
 
         if (MutationObserver)
           new MutationObserver(collapseElement).observe(
             element, {
               attributes: true,
               attributeFilter: ["style"]
             }
@@ skipping 394 matching lines @@
   }, true);
 
   return updateStylesheet;
 }
 
 if (document instanceof HTMLDocument)
 {
   checkSitekey();
   window.updateStylesheet = init(document);
 }