Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(341)

Issue 29348920: Issue 3767 - Update README to reflect build changes in 44.0.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by diegocarloslima
Modified:
3 years, 1 month ago
Reviewers:
Felix Dahlke, anton
CC:
René Jeschke
Visibility:
Public.

Description

Issue 3767 - Update README to reflect build changes in 44.0.2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M README.md View 3 chunks +4 lines, -14 lines 1 comment Download

Messages

Total messages: 5
diegocarloslima
3 years, 4 months ago (2016-07-29 22:10:58 UTC) #1
anton
https://codereview.adblockplus.org/29348920/diff/29348921/README.md File README.md (left): https://codereview.adblockplus.org/29348920/diff/29348921/README.md#oldcode25 README.md:25: (Follow-up issue: https://issues.adblockplus.org/ticket/2490) currently it's also in reviewing state ...
3 years, 2 months ago (2016-09-12 11:29:26 UTC) #2
diegocarloslima
On 2016/09/12 11:29:26, anton wrote: > https://codereview.adblockplus.org/29348920/diff/29348921/README.md > File README.md (left): > > https://codereview.adblockplus.org/29348920/diff/29348921/README.md#oldcode25 > ...
3 years, 1 month ago (2016-10-20 10:17:19 UTC) #3
Felix Dahlke
LGTM, though I guess the README change regarding #2490 makes more sense along with the ...
3 years, 1 month ago (2016-10-25 15:18:20 UTC) #4
anton
3 years, 1 month ago (2016-11-02 14:03:17 UTC) #5
On 2016/10/20 10:17:19, diegocarloslima wrote:
> On 2016/09/12 11:29:26, anton wrote:
> > https://codereview.adblockplus.org/29348920/diff/29348921/README.md
> > File README.md (left):
> > 
> >
https://codereview.adblockplus.org/29348920/diff/29348921/README.md#oldcode25
> > README.md:25: (Follow-up issue: https://issues.adblockplus.org/ticket/2490)
> > currently it's also in reviewing state and i'd prefer this issue (and review
> > https://codereview.adblockplus.org/29342994/) to be closed too. Please
> consider
> > adding code reviews dependencies too (like #depends on .. for this one)
> 
> Added dependency to the ticket

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5