Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29348972: Issue 4239 - Change indentation to reflect our coding style (Closed)

Created:
Aug. 2, 2016, 10:43 a.m. by anton
Modified:
Sept. 15, 2016, 11:52 a.m.
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4239 - Change indentation to reflect our coding style applied to both library and tests (master)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+7602 lines, -7045 lines) Patch
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyLogSystem.java View 1 chunk +4 lines, -4 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java View 1 chunk +5 lines, -5 lines 2 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockFilterChangeCallback.java View 1 chunk +14 lines, -14 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockLogSystem.java View 1 chunk +28 lines, -28 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockUpdateAvailableCallback.java View 1 chunk +14 lines, -14 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/MockWebRequest.java View 1 chunk +5 lines, -5 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/NoOpUpdaterCallback.java View 1 chunk +4 lines, -4 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingLogSystem.java View 1 chunk +5 lines, -5 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/ThrowingWebRequest.java View 1 chunk +5 lines, -5 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestTest.java View 1 chunk +75 lines, -75 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AppInfoJsObjectTest.java View 1 chunk +34 lines, -34 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/BaseJsTest.java View 1 chunk +10 lines, -10 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/ConsoleJsObjectTest.java View 1 chunk +67 lines, -67 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineGenericTest.java View 1 chunk +9 lines, -9 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineTest.java View 1 chunk +350 lines, -350 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/FilterEngineUpdaterTest.java View 1 chunk +23 lines, -23 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/GlobalJsObjectTest.java View 1 chunk +42 lines, -42 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsEngineTest.java View 1 chunk +92 lines, -92 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/JsTest.java View 1 chunk +206 lines, -205 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/MockWebRequestTest.java View 1 chunk +96 lines, -96 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/NotificationTest.java View 1 chunk +117 lines, -115 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdateCheckTest.java View 1 chunk +214 lines, -214 lines 0 comments Download
M libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/UpdaterTest.java View 1 chunk +21 lines, -21 lines 0 comments Download
M libadblockplus-android/src/org/apache/commons/lang/CharUtils.java View 1 chunk +561 lines, -514 lines 1 comment Download
M libadblockplus-android/src/org/apache/commons/lang/StringEscapeUtils.java View 1 chunk +599 lines, -533 lines 0 comments Download
M libadblockplus-android/src/org/apache/commons/lang/StringUtils.java View 4 chunks +5002 lines, -4561 lines 0 comments Download

Messages

Total messages: 4
anton
https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android/src/org/apache/commons/lang/CharUtils.java File libadblockplus-android/src/org/apache/commons/lang/CharUtils.java (right): https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android/src/org/apache/commons/lang/CharUtils.java#newcode34 libadblockplus-android/src/org/apache/commons/lang/CharUtils.java:34: public class CharUtils applied indentation to Apache classes too ...
Aug. 2, 2016, 10:45 a.m. (2016-08-02 10:45:35 UTC) #1
diegocarloslima
On 2016/08/02 10:45:35, anton wrote: > https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android/src/org/apache/commons/lang/CharUtils.java > File libadblockplus-android/src/org/apache/commons/lang/CharUtils.java (right): > > https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android/src/org/apache/commons/lang/CharUtils.java#newcode34 > ...
Sept. 9, 2016, 1:11 a.m. (2016-09-09 01:11:33 UTC) #2
Felix Dahlke
LGTM, but I didn't check incredibly thoroughly :) https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java (right): https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java#newcode27 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java:27: while ...
Sept. 12, 2016, 1:59 p.m. (2016-09-12 13:59:00 UTC) #3
anton
Sept. 13, 2016, 5:51 a.m. (2016-09-13 05:51:45 UTC) #4
https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-andr...
File
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java
(right):

https://codereview.adblockplus.org/29348972/diff/29348973/libadblockplus-andr...
libadblockplus-android-tests/src/org/adblockplus/libadblockplus/LazyWebRequest.java:27:
while (true) ;
On 2016/09/12 13:59:00, Felix Dahlke wrote:
> Not sure why there was a space added before the semicolon, but the code will
be
> replaced anyway (to include those braces).

yes, it will be:

"while(true)
{
}"

Powered by Google App Engine
This is Rietveld