Delta Between Two Patch Sets: templates/default.tmpl
Issue 29349015:
Issue 4301 - Add Privacy Policy to Eyeo.com (Closed)
Left Patch Set:
Created Aug. 3, 2016, 3:14 p.m.
Right Patch Set: Addressed Julian's comments
Created Aug. 16, 2016, 10:17 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« static/css/styles.css ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <html lang="{{locale}}"> | 2 <html lang="{{locale}}"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="UTF-8" /> | 4 <meta charset="UTF-8" /> |
| 5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> | 5 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no" /> |
| 6 <meta http-equiv="X-UA-Compatible" content="IE=edge"> | 6 <meta http-equiv="X-UA-Compatible" content="IE=edge"> |
| 7 | 7 |
| 8 {% if title %} | 8 {% if title %} |
| 9 <title>{{title}} | Eyeo GmbH</title> | 9 <title>{{title}} | Eyeo GmbH</title> |
| 10 {% else %} | 10 {% else %} |
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 76 | 76 |
| 77 </div> | 77 </div> |
| 78 </header> | 78 </header> |
| 79 | 79 |
| 80 <div id="content"> | 80 <div id="content"> |
| 81 {{body|safe}} | 81 {{body|safe}} |
| 82 </div> | 82 </div> |
| 83 | 83 |
| 84 <footer id="footer"> | 84 <footer id="footer"> |
| 85 <div class="content-block"> | 85 <div class="content-block"> |
| 86 <span> | 86 <small> |
|
juliandoucette
2016/08/12 19:04:13
NIT: I think a <small> tag makes more sense than a
saroyanm
2016/08/16 10:20:27
Done, had to update styles, otherwise the text was
| |
| 87 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH . | 87 Adblock Plus™ and Acceptable Ads™ are registered trademarks of Eyeo GmbH . |
| 88 </span> | 88 </small> |
| 89 <div id="footer-links"> | 89 <div id="footer-links"> |
| 90 <a href="{{source.resolve_link("contact", locale)[1]}}" hreflang="{{sour ce.resolve_link("contact", locale)[0]}}"> | 90 {{"contact"|linkify}}Made with ♥ in Cologne</a> |
| 91 Made with ♥ in Cologne | 91 {{"privacy"|linkify}}Privacy Policy</a> |
| 92 </a> | |
| 93 <a href="{{source.resolve_link("privacy", locale)[1]}}" hreflang="{{sour ce.resolve_link("privacy", locale)[0]}}"> | |
|
juliandoucette
2016/08/12 19:04:13
Q: Why did you choose to use source.resolve_link i
saroyanm
2016/08/16 10:20:27
Kept previous style, but you are totally right, I
| |
| 94 Privacy Policy | |
| 95 </a> | |
| 96 </div> | 92 </div> |
| 97 </div> | 93 </div> |
| 98 </footer> | 94 </footer> |
| 99 </body> | 95 </body> |
| 100 | 96 |
| 101 </html> | 97 </html> |
| LEFT | RIGHT |
« static/css/styles.css ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
