Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(276)

Issue 29349024: Issue 4298 - Enforce 'display: none' for ElemHide (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by kzar
Modified:
3 years, 1 month ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 4298 - Enforce 'display: none' for ElemHide Based upon the code in these reviews: https://codereview.adblockplus.org/29347034/ https://codereview.adblockplus.org/29348917/

Patch Set 1 #

Total comments: 4

Patch Set 2 : Block access to rules instead of attempting to enforce rule styles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M include.preload.js View 1 3 chunks +27 lines, -15 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
3 years, 1 month ago (2016-08-04 15:24:50 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29349024/diff/29349025/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29349024/diff/29349025/include.preload.js#newcode347 include.preload.js:347: Object.defineProperty(style.sheet, "disabled", Where did the code go, that addressed ...
3 years, 1 month ago (2016-08-04 20:44:23 UTC) #2
kzar
Patch Set 2 : Block access to rules instead of attempting to enforce rule styles ...
3 years, 1 month ago (2016-08-05 11:01:57 UTC) #3
Sebastian Noack
I suppose the changes here got redundant, with the changes for #4191 preventing access to ...
3 years, 1 month ago (2016-08-11 13:13:19 UTC) #4
kzar
3 years, 1 month ago (2016-08-11 13:26:50 UTC) #5
On 2016/08/11 13:13:19, Sebastian Noack wrote:
> I suppose the changes here got redundant, with the changes for #4191
preventing
> access to the shadow DOM.

Correct, closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5