Issue 29349184: Noissue - Ignore unrelated notification clicks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29349184: Noissue - Ignore unrelated notification clicks (Closed)

Created:
Aug. 8, 2016, 3:05 p.m. by kzar

Modified:
Dec. 18, 2016, 2:45 a.m.

Reviewers:
Sebastian Noack, jojonyx37

CC:
brent_getadblock.com

Visibility:
Public.

Description

Noissue - Ignore unrelated notification clicks To test enter this code in the background console and then click the "CLICK HERE PLEASE" button in the notification. Before the changes this results in an exception. chrome.notifications.create({type: "basic", iconUrl: "icons/abp-16.png", title: "Hello title", message: "Hello world", isClickable: true, buttons: [{title: "CLICK HERE PLEASE"}]})

Patch Set 1 #

Created: Aug. 8, 2016, 3:05 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	lib/notificationHelper.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

Expand All Messages | Collapse All Messages