Issue 4167 - getSelectorsForDomain criteria + keys

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 166 matching lines @@
   addFilter("##hello");
   addFilter("~example.com##world");
   addFilter("foo.com##specific");
   testResult("foo.com", ["specific"], ElemHide.SPECIFIC_ONLY);
   testResult("foo.com", ["specific", "world"], ElemHide.NO_UNCONDITIONAL);
   testResult("foo.com", ["hello", "specific", "world"], ElemHide.ALL_MATCHING);
   testResult("foo.com", ["hello", "specific", "world"]);
   removeFilter("foo.com##specific");
   removeFilter("~example.com##world");
   removeFilter("##hello");
+  testResult("foo.com", []);
+
+  addFilter("##hello");
+  testResult("foo.com", [], ElemHide.SPECIFIC_ONLY);
+  testResult("foo.com", [], ElemHide.NO_UNCONDITIONAL);
+  testResult("foo.com", ["hello"], ElemHide.ALL_MATCHING);
+  testResult("foo.com", ["hello"]);
+  testResult("bar.com", [], ElemHide.SPECIFIC_ONLY);
+  testResult("bar.com", [], ElemHide.NO_UNCONDITIONAL);
+  testResult("bar.com", ["hello"], ElemHide.ALL_MATCHING);
+  testResult("bar.com", ["hello"]);
+  addFilter("foo.com#@#hello");
+  testResult("foo.com", [], ElemHide.SPECIFIC_ONLY);
+  testResult("foo.com", [], ElemHide.NO_UNCONDITIONAL);
+  testResult("foo.com", [], ElemHide.ALL_MATCHING);
+  testResult("foo.com", []);
+  testResult("bar.com", [], ElemHide.SPECIFIC_ONLY);
+  testResult("bar.com", ["hello"], ElemHide.NO_UNCONDITIONAL);
+  testResult("bar.com", ["hello"], ElemHide.ALL_MATCHING);
+  testResult("bar.com", ["hello"]);
+  removeFilter("foo.com#@#hello");
+  testResult("foo.com", [], ElemHide.SPECIFIC_ONLY);
+  // Note: We don't take care to track conditional selectors which became
+  //       unconditional when a filter was removed. This was too expensive.
+  //testResult("foo.com", [], ElemHide.NO_UNCONDITIONAL);
+  testResult("foo.com", ["hello"], ElemHide.ALL_MATCHING);
+  testResult("foo.com", ["hello"]);
+  testResult("bar.com", [], ElemHide.SPECIFIC_ONLY);
+  testResult("bar.com", ["hello"], ElemHide.NO_UNCONDITIONAL);
+  testResult("bar.com", ["hello"], ElemHide.ALL_MATCHING);
+  testResult("bar.com", ["hello"]);
+  removeFilter("##hello");
+  testResult("foo.com", []);
+  testResult("bar.com", []);
 
   addFilter("##hello");
   addFilter("foo.com##hello");
   testResult("foo.com", ["hello"]);
   removeFilter("foo.com##hello");
   testResult("foo.com", ["hello"]);
   removeFilter("##hello");

[Wladimir Palant, 2016/09/26 14:56:54]

How about:

  testResult("foo.com", []);

This is just begging for you to check the final state - that this selectors goes
away after you remove all filters.

[kzar, 2016/09/27 12:40:22]

Done.

+  testResult("foo.com", []);
 
   addFilter("##hello");
   addFilter("foo.com##hello");
   testResult("foo.com", ["hello"]);
   removeFilter("##hello");
   testResult("foo.com", ["hello"]);
   removeFilter("foo.com##hello");

[Wladimir Palant, 2016/09/26 14:56:54]

Same here, how about testing the final state?

[kzar, 2016/09/27 12:40:22]

Done.

+  testResult("foo.com", []);
 

[Wladimir Palant, 2016/09/26 14:56:54]

How about testing the combination of ##hello and foo.com#@#hello? Also what you
get after removing foo.com#@#hello. I don't see any other test forcing an
unconditional filter to by-domain maps right now.

[kzar, 2016/09/27 12:40:22]

Done.

   // Advanced filter keys test
   testResult("", []);
   addFilter("##dupe");
   addFilter(",,##dupe");
   addFilter(",,,##dupe");
   addFilter("foo.com##dupe");
   testResult("", ["dupe"]);
   removeFilter(",,,##dupe");
   testResult("", ["dupe"]);
   removeFilter("foo.com##dupe");
   testResult("", ["dupe"]);
   removeFilter(",,##dupe");
   testResult("", ["dupe"]);
   removeFilter("##dupe");
   testResult("", []);
 
   test.done();
 };